Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trigger mouse events at the center of arc #5991

Merged
merged 1 commit into from
Jan 18, 2019

Conversation

kurkle
Copy link
Member

@kurkle kurkle commented Jan 18, 2019

Tests were failing in my development machine. I wonder how they pass here.
Arc x,y are at the center of chart for polar area - so not really over a particular arc.

@kurkle kurkle requested a review from etimberg January 18, 2019 08:08
@etimberg
Copy link
Member

Not sure how it worked before. I had quickly looked at centerX and centerY getting set on the model in the controller and assumed those were for the arc.

@etimberg etimberg merged commit d9012d9 into chartjs:master Jan 18, 2019
@simonbrunel
Copy link
Member

Instead, I would have changed the triggerMouseEvent() to fallback to getCenterPoint().

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants