Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reset only when animating #4923

Merged
merged 1 commit into from
Nov 7, 2017
Merged

Conversation

benmccann
Copy link
Contributor

This is a performance improvement for charts that are not animated as discussed in #4865

helpers.each(newControllers, function(controller) {
controller.reset();
});
if (me.options.animation.duration) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Animations are also disabled when animation is false (or null)

if (me.options.animation && me.options.animation.duration) {
    // ...
}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! done

@simonbrunel simonbrunel added this to the Version 2.8 milestone Nov 7, 2017
@etimberg etimberg merged commit d415e61 into chartjs:master Nov 7, 2017
yofreke pushed a commit to yofreke/Chart.js that referenced this pull request Dec 30, 2017
exwm pushed a commit to exwm/Chart.js that referenced this pull request Apr 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants