Make sure to always set the label font colour when rendering tooltip text #4766
Conversation
|
I think there's some kind of race condition that's making Travis fail |
|
I'm curious what the plan is for 2.7.1. Do we need to tag the PRs that we want to be a part of that release with a milestone of 2.7.1 to cherrypick those commits? Or will we at that time take the latest master and merge all the commits to the release branch? |
|
@benmccann what we've been doing so far is just merging bug fixes and holding on the features until we get an idea if we need a 2.7.1 or not |
|
Ok, that makes sense. Thanks for filling me in! |
| } | ||
|
|
||
| var textColor = mergeOpacity(vm.labelTextColors[i], opacity); | ||
| ctx.fillStyle = textColor; | ||
| fillLineOfText(line); |
There was a problem hiding this comment.
You could combine these two lines into one:
ctx.fillStyle = mergeOpacity(vm.labelTextColors[i], opacity);
It might be better for minification / download size that way
| } | ||
|
|
||
| var textColor = mergeOpacity(vm.labelTextColors[i], opacity); |
There was a problem hiding this comment.
Before introducing this bug, the fillStyle was set before all the loops, meaning that beforeBody and bodyItem.before was also supposed to be drawn using bodyFontColor. Not sure if that still work, there is no more ctx.fillStyle initialization?
|
@etimberg Any updates on this? We’re seeing this bug in certain circumstances and I'd love to see a 2.7.1 with a fix! |
|
It would be have this released - we need the tooltips colours fixed |
|
Done in #4783 |
Resolves #4741