Add CanvasPattern support to tooltip #4284
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etimberg
requested changes
May 24, 2017
| @@ -691,7 +691,14 @@ module.exports = function(Chart) { | |||
| ctx.strokeRect(pt.x, pt.y, bodyFontSize, bodyFontSize); | |||
|
|
|||
| // Inner square | |||
| ctx.fillStyle = mergeOpacity(vm.labelColors[i].backgroundColor, opacity); | |||
| var bgColor = vm.labelColors[i].backgroundColor; | |||
| if (bgColor instanceof CanvasPattern) { | |||
There was a problem hiding this comment.
I think it would be a good idea to check for CanvasGradient as well too
|
@swierczek @etimberg Any update on merging this? |
|
@ChrisKatsaras my comments above need to be addressed before merging and tests need to be written. I'm not sure if @swierczek planned to do them or not. |
|
I agree! @swierczek any idea when you will implement these changes? |
|
Checking it out now, sorry this was part of another project and once I figured it out I made the PR and promptly forgot about it ;) |
|
@swierczek do you still plan to make those updates? |
|
I took a stab at it a while back but again it fell off my radar... someone else is more than welcome to make these additional changes instead of waiting on me |
|
Closing due to inactivity |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #4279 and subsequently ashiguruma/patternomaly#10