Fixed bug with bezier still being used with tension set to 0

[hallatore]

According to the docs bezier curve should be disabled when tension is set to 0.

[etimberg]

Not entirely sure that this is needed. A bezier tension of 0 will draw straight lines. Have you been running into scenarios where a tension of 0 is not giving straight lines?

[hallatore]

@etimberg Bezier with tension set around 0 will cause artifacts.

tension set to 0
Original code: http://i.imgur.com/5ePYdRv.png
New code: http://i.imgur.com/E46Egko.png

[etimberg]

Ok, I'll merge this as soon as the tests pass 😄

[hallatore]

@etimberg You fix the tests or I?

I'm not sure where to get the options object from that part of the code if this._chart is not available.

[etimberg]

If you could fix the tests, that'd be great.

I think you should have access to the tension as this._model.tension per https://github.com/nnnick/Chart.js/blob/v2.0-dev/src/controllers/controller.line.js#L90

If you want the animated tension, look in this._view.tension but I think you want the non animated one in this case. There are two possible correct solutions: Check the tension in this._model.tension or change the line controller so that the property is _tension (properties with an underscore at the start of the name are not animated) and then check this._view._tension

[hallatore]

@etimberg Would this work?

[etimberg]

Yup. The only thing that might be a problem is if the user animates the bezier curve tension to 0. That is highly unlikely however.

[etimberg]

Thanks again @hallatore