Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

line-customTooltips.html doesn't take the scroll offset into account #4038

Closed
el-ee opened this issue Mar 16, 2017 · 2 comments
Closed

line-customTooltips.html doesn't take the scroll offset into account #4038

el-ee opened this issue Mar 16, 2017 · 2 comments

Comments

@el-ee
Copy link
Contributor

el-ee commented Mar 16, 2017

The example file line-customTooltips.html doesn't take the window scroll offset into account, which leads to some confusion when you're trying to use the example to figure out how custom tooltips work, and they show up off-screen making you think something is wrong when it's maybe not!

Just needs this small change:

el-ee@d851295

@etimberg
Copy link
Member

@el-ee good catch! Could you PR a fix for that?

@etimberg
Copy link
Member

Resolved in #4039

etimberg pushed a commit that referenced this issue Mar 22, 2017
Add window scroll position to tooltip position calculation so they show up in the intended place instead of potentially off-screen! Moved tooltips inside the canvas parent container since they are being positioned in terms of its location
@etimberg etimberg added this to the Version 2.6 milestone Mar 22, 2017
roicos pushed a commit to roicos/Chart.js that referenced this issue Aug 21, 2017
Add window scroll position to tooltip position calculation so they show up in the intended place instead of potentially off-screen! Moved tooltips inside the canvas parent container since they are being positioned in terms of its location
exwm pushed a commit to exwm/Chart.js that referenced this issue Apr 30, 2021
Add window scroll position to tooltip position calculation so they show up in the intended place instead of potentially off-screen! Moved tooltips inside the canvas parent container since they are being positioned in terms of its location
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants