Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bar chart with x time scale (tooltips) not correct #11229

Closed
danielvanmil opened this issue Apr 13, 2023 · 5 comments
Closed

Bar chart with x time scale (tooltips) not correct #11229

danielvanmil opened this issue Apr 13, 2023 · 5 comments

Comments

@danielvanmil
Copy link

danielvanmil commented Apr 13, 2023

Expected behavior

See https://www.chartjs.org/docs/latest/samples/scales/time-combo.html, The tooltips should be correct

Current behavior

See https://www.chartjs.org/docs/latest/samples/scales/time-combo.html, The tooltips show the wrong date (17 instead of 18)

image

Reproducible sample

https://www.chartjs.org/docs/latest/samples/scales/time-combo.html

Optional extra steps/info to reproduce

No response

Possible solution

No response

Context

No response

chart.js version

4.2.1

Browser name and version

No response

Link to your project

No response

@stockiNail
Copy link
Contributor

I think the sample should be changed adding the ticks.source:

        ticks: {
          source: 'data'
        },

@mukham12
Copy link
Contributor

mukham12 commented May 7, 2023

Hi @stockiNail,

Are you suggesting that I add this to the following file somewhere after line 68:

If so, I would be happy to contribute and create a PR. This seems like an excellent opportunity for me to make my first contribution. Thank you for your attention!

@stockiNail
Copy link
Contributor

@mukham12 yes, I was suggesting that. Feel free to submit a PR!

@mukham12
Copy link
Contributor

mukham12 commented May 8, 2023

Many thanks @stockiNail. I will try to submit a PR as soon as I am able to. I appreciate the support.

@mukham12
Copy link
Contributor

mukham12 commented Jun 3, 2023

Hi @etimberg,

Now that the PR has been merged, can we consider closing this issue?

Also, it looks like issue #10889 shares similarities with this one, so it would be great if we could address that as well and close it if appropriate.

Thank you!

@etimberg etimberg closed this as completed Jun 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants