Skip to content

Commit

Permalink
Code review updates
Browse files Browse the repository at this point in the history
  • Loading branch information
etimberg committed Nov 6, 2019
1 parent 10650c6 commit 907b081
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 6 deletions.
2 changes: 1 addition & 1 deletion docs/getting-started/v3-migration.md
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ Chart.js is no longer providing the `Chart.bundle.js` and `Chart.bundle.min.js`.
### Customizability

* `custom` attribute of elements was removed. Please use scriptable options
* The `zeroLine*` features of axes were removed.
* The `zeroLine*` options of axes were removed.

### Options

Expand Down
10 changes: 5 additions & 5 deletions src/core/core.scale.js
Original file line number Diff line number Diff line change
Expand Up @@ -974,7 +974,7 @@ var Scale = Element.extend({
return alignPixel(chart, pixel, axisWidth);
};
var borderValue, i, tick, lineValue, alignedLineValue;
var tx1, ty1, tx2, ty2, x1, y1, x2, y2, lineWidth, lineColor, borderDash, borderDashOffset;
var tx1, ty1, tx2, ty2, x1, y1, x2, y2;

if (position === 'top') {
borderValue = alignBorderValue(me.bottom);
Expand Down Expand Up @@ -1005,10 +1005,10 @@ var Scale = Element.extend({
for (i = 0; i < ticksLength; ++i) {
tick = ticks[i] || {};

lineWidth = valueAtIndexOrDefault(gridLines.lineWidth, i, 1);
lineColor = valueAtIndexOrDefault(gridLines.color, i, 'rgba(0,0,0,0.1)');
borderDash = gridLines.borderDash || [];
borderDashOffset = gridLines.borderDashOffset || 0.0;
const lineWidth = valueAtIndexOrDefault(gridLines.lineWidth, i, 1);
const lineColor = valueAtIndexOrDefault(gridLines.color, i, 'rgba(0,0,0,0.1)');
const borderDash = gridLines.borderDash || [];
const borderDashOffset = gridLines.borderDashOffset || 0.0;

lineValue = getPixelForGridLine(me, tick._index || i, offsetGridLines);

Expand Down

0 comments on commit 907b081

Please sign in to comment.