fix: use safeWriter to guard writing to output #1140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aymanbagabas
force-pushed
the
v2-sync
branch
2 times, most recently
from
31e7e04 to
1e530ba
Compare
caarlos0
approved these changes
Sep 12, 2024
This implements a wrapper around p.output that locks the output on every write. We also need to redefine `channelHandlers` to be thread-safe since `p.Kill()` can be called from a different thread while the program is running.
aymanbagabas
force-pushed
the
v2-sync
branch
from
2aaee44 to
1d5b873
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements a wrapper around p.output that locks the output on every write. We also need to redefine
channelHandlersto be thread-safe sincep.Kill()can be called from a different thread while the program is running.