-
Notifications
You must be signed in to change notification settings - Fork 855
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
First line not rendering until event happens #1000
Comments
Noted, thanks for the report, Tyler. I'm able to reproduce on various terminals on macOS. Just so we can diagnose properly, would you mind posting a screenshot of the actual expected outputs together? |
aymanbagabas
added a commit
that referenced
this issue
May 8, 2024
Before switching to golang/term for terminal handling, we used containerd/console. Which by default, uses Termios OPOST when setting the terminal to raw mode. This is needed because we need to post process output to render the terminal correctly. This also switches to using charmbracelet/x/exp/term since golang/term doesn't allow setting a custom Termios settings. Fixes: #1000 Fixes: 4624106 (feat: reduce console/term dependencies (#897))
aymanbagabas
added a commit
that referenced
this issue
May 8, 2024
Before switching to golang/term for terminal handling, we used containerd/console. Which by default, uses Termios OPOST when setting the terminal to raw mode. This is needed because we need to post process output to render the terminal correctly. This also switches to using charmbracelet/x/exp/term since golang/term doesn't allow setting a custom Termios settings. Fixes: #1000 Fixes: 4624106 (feat: reduce console/term dependencies (#897))
Thanks again for reporting this, @mistakenelf — extremely appreciated. @aymanbagabas fixed this like a pro and we're releasing Bubble Tea v0.26.2 with the fix in a few minutes. |
cuixq
referenced
this issue
in google/osv-scanner
May 24, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/charmbracelet/bubbletea](https://togithub.com/charmbracelet/bubbletea) | `v0.26.1` -> `v0.26.2` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [github.com/package-url/packageurl-go](https://togithub.com/package-url/packageurl-go) | `v0.1.2` -> `v0.1.3` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | golang.org/x/exp | `v0.0.0-20240416160154-fe59bbe5cc7f` -> `v0.0.0-20240506185415-9bf2ced13842` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [google.golang.org/grpc](https://togithub.com/grpc/grpc-go) | `v1.63.2` -> `v1.64.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [google.golang.org/protobuf](https://togithub.com/protocolbuffers/protobuf-go) | `v1.34.0` -> `v1.34.1` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>charmbracelet/bubbletea (github.com/charmbracelet/bubbletea)</summary> ### [`v0.26.2`](https://togithub.com/charmbracelet/bubbletea/releases/tag/v0.26.2) [Compare Source](https://togithub.com/charmbracelet/bubbletea/compare/v0.26.1...v0.26.2) This fixes a small regression that was introduced in v0.26.0 related to the first line on the first render not being displayed correctly. Thank you [@​mistakenelf](https://togithub.com/mistakenelf) for pointing this out in [https://github.com/charmbracelet/bubbletea/issues/1000](https://togithub.com/charmbracelet/bubbletea/issues/1000)! #### What's Changed - fix: stop and drain timers by [@​caarlos0](https://togithub.com/caarlos0) in [https://github.com/charmbracelet/bubbletea/pull/993](https://togithub.com/charmbracelet/bubbletea/pull/993) - chore(lint): minor lint-related improvements by [@​meowgorithm](https://togithub.com/meowgorithm) in [https://github.com/charmbracelet/bubbletea/pull/1007](https://togithub.com/charmbracelet/bubbletea/pull/1007) - fix: renderer: reset the cursor on the first line by [@​aymanbagabas](https://togithub.com/aymanbagabas) in [https://github.com/charmbracelet/bubbletea/pull/1008](https://togithub.com/charmbracelet/bubbletea/pull/1008) - chore(deps): bump golang.org/x/sys from 0.19.0 to 0.20.0 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/charmbracelet/bubbletea/pull/1003](https://togithub.com/charmbracelet/bubbletea/pull/1003) - chore(deps): bump golangci/golangci-lint-action from 5 to 6 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/charmbracelet/bubbletea/pull/1005](https://togithub.com/charmbracelet/bubbletea/pull/1005) - chore(deps): bump golang.org/x/term from 0.19.0 to 0.20.0 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/charmbracelet/bubbletea/pull/1002](https://togithub.com/charmbracelet/bubbletea/pull/1002) **Full Changelog**: charmbracelet/bubbletea@v0.26.1...v0.26.2 *** <a href="https://charm.sh/"><img alt="The Charm logo" src="https://stuff.charm.sh/charm-badge.jpg" width="400"></a> Thoughts? Questions? We love hearing from you. Feel free to reach out on [Twitter](https://twitter.com/charmcli), [The Fediverse](https://mastodon.social/@​charmcli), or [Discord](https://charm.sh/chat). </details> <details> <summary>package-url/packageurl-go (github.com/package-url/packageurl-go)</summary> ### [`v0.1.3`](https://togithub.com/package-url/packageurl-go/releases/tag/v0.1.3) [Compare Source](https://togithub.com/package-url/packageurl-go/compare/v0.1.2...v0.1.3) #### What's Changed - go.mod: Bump required Go version to 1.18 by [@​magnusbaeck](https://togithub.com/magnusbaeck) in [https://github.com/package-url/packageurl-go/pull/66](https://togithub.com/package-url/packageurl-go/pull/66) - Fix Github Actions by [@​shibumi](https://togithub.com/shibumi) in [https://github.com/package-url/packageurl-go/pull/69](https://togithub.com/package-url/packageurl-go/pull/69) - Adds `./` and `../` as valid subpath prefix by [@​ridhoq](https://togithub.com/ridhoq) in [https://github.com/package-url/packageurl-go/pull/68](https://togithub.com/package-url/packageurl-go/pull/68) #### New Contributors - [@​magnusbaeck](https://togithub.com/magnusbaeck) made their first contribution in [https://github.com/package-url/packageurl-go/pull/66](https://togithub.com/package-url/packageurl-go/pull/66) - [@​ridhoq](https://togithub.com/ridhoq) made their first contribution in [https://github.com/package-url/packageurl-go/pull/68](https://togithub.com/package-url/packageurl-go/pull/68) **Full Changelog**: package-url/packageurl-go@v0.1.2...v0.1.3 </details> <details> <summary>grpc/grpc-go (google.golang.org/grpc)</summary> ### [`v1.64.0`](https://togithub.com/grpc/grpc-go/releases/tag/v1.64.0): Release 1.64.0 [Compare Source](https://togithub.com/grpc/grpc-go/compare/v1.63.2...v1.64.0) ### API Changes - stats: Deprecate `InPayload.Data` and `OutPayload.Data`; they were experimental and will be deleted in the next release ([#​7121](https://togithub.com/grpc/grpc-go/issues/7121)) ### Behavior Changes - codec: Remove handling of environment variable `GRPC_GO_ADVERTISE_COMPRESSORS` to suppress setting supported compressors in `grpc-accept-encoding` header. Compressors will always be advertised, as they have been by default for some time ([#​7203](https://togithub.com/grpc/grpc-go/issues/7203)) ### New Features - resolver/dns: Add `SetMinResolutionInterval` to set the minimum interval at which DNS re-resolutions may occur ([#​6962](https://togithub.com/grpc/grpc-go/issues/6962)) - Special Thanks: [@​HomayoonAlimohammadi](https://togithub.com/HomayoonAlimohammadi) - peer/peer: Implement the `fmt.Stringer` interface for pretty printing `Peer`, and - metadata/metadata: Implement the `fmt.Stringer` interface for pretty printing `MD` ([#​7137](https://togithub.com/grpc/grpc-go/issues/7137)) - Special Thanks: [@​AnomalRoil](https://togithub.com/AnomalRoil) ### Performance Improvements - client: Improve RPC performance by reducing work while holding a lock ([#​7132](https://togithub.com/grpc/grpc-go/issues/7132)) ### Bug Fixes - transport/server: Display the proper timeout value when keepalive pings are not ack'd in time ([#​7038](https://togithub.com/grpc/grpc-go/issues/7038)) - Special Thanks: [@​BatmanAoD](https://togithub.com/BatmanAoD) - channelz: Fix bug that was causing the subchannel's target to be unset ([#​7189](https://togithub.com/grpc/grpc-go/issues/7189)) - stats: Fix bug where peer was not set in context when calling stats handler for `OutPayload`, `InPayload`, and `End` ([#​7096](https://togithub.com/grpc/grpc-go/issues/7096)) ### Dependencies - deps: Remove dependency on deprecated `github.com/golang/protobuf` module ([#​7122](https://togithub.com/grpc/grpc-go/issues/7122)) ### Documentation - grpc: Deprecate `WithBlock`, `WithReturnConnectionError`, `FailOnNonTempDialError` which are ignored by `NewClient` ([#​7097](https://togithub.com/grpc/grpc-go/issues/7097)) - Special Thanks: [@​pellared](https://togithub.com/pellared) - grpc: Deprecate `Dial` and `DialContext`. These will continue to be supported throughout 1.x, but are deprecated to direct users to `NewClient` (See [#​7090](https://togithub.com/grpc/grpc-go/issues/7090) for more information) - examples: Add custom lb example ([#​6691](https://togithub.com/grpc/grpc-go/issues/6691)) </details> <details> <summary>protocolbuffers/protobuf-go (google.golang.org/protobuf)</summary> ### [`v1.34.1`](https://togithub.com/protocolbuffers/protobuf-go/releases/tag/v1.34.1) [Compare Source](https://togithub.com/protocolbuffers/protobuf-go/compare/v1.34.0...v1.34.1) Minor fixes for editions compliance: - [CL/582635](https://go.dev/cl/582635): all: update to protobuf 27.0-rc1 and regenerate protos - [CL/582755](https://go.dev/cl/582755): encoding/proto\[json|text]: accept lower case names for group-like fields </details> --- ### Configuration 📅 **Schedule**: Branch creation - "before 6am on monday" in timezone Australia/Sydney, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://togithub.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/google/osv-scanner). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zNTEuMiIsInVwZGF0ZWRJblZlciI6IjM3LjM2My41IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJkZXBlbmRlbmNpZXMiXX0=--> --------- Co-authored-by: Xueqin Cui <72771658+cuixq@users.noreply.github.com>
josieang
referenced
this issue
in josieang/osv-scanner
Jun 6, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/charmbracelet/bubbletea](https://togithub.com/charmbracelet/bubbletea) | `v0.26.1` -> `v0.26.2` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [github.com/package-url/packageurl-go](https://togithub.com/package-url/packageurl-go) | `v0.1.2` -> `v0.1.3` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | golang.org/x/exp | `v0.0.0-20240416160154-fe59bbe5cc7f` -> `v0.0.0-20240506185415-9bf2ced13842` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [google.golang.org/grpc](https://togithub.com/grpc/grpc-go) | `v1.63.2` -> `v1.64.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [google.golang.org/protobuf](https://togithub.com/protocolbuffers/protobuf-go) | `v1.34.0` -> `v1.34.1` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>charmbracelet/bubbletea (github.com/charmbracelet/bubbletea)</summary> ### [`v0.26.2`](https://togithub.com/charmbracelet/bubbletea/releases/tag/v0.26.2) [Compare Source](https://togithub.com/charmbracelet/bubbletea/compare/v0.26.1...v0.26.2) This fixes a small regression that was introduced in v0.26.0 related to the first line on the first render not being displayed correctly. Thank you [@​mistakenelf](https://togithub.com/mistakenelf) for pointing this out in [https://github.com/charmbracelet/bubbletea/issues/1000](https://togithub.com/charmbracelet/bubbletea/issues/1000)! #### What's Changed - fix: stop and drain timers by [@​caarlos0](https://togithub.com/caarlos0) in [https://github.com/charmbracelet/bubbletea/pull/993](https://togithub.com/charmbracelet/bubbletea/pull/993) - chore(lint): minor lint-related improvements by [@​meowgorithm](https://togithub.com/meowgorithm) in [https://github.com/charmbracelet/bubbletea/pull/1007](https://togithub.com/charmbracelet/bubbletea/pull/1007) - fix: renderer: reset the cursor on the first line by [@​aymanbagabas](https://togithub.com/aymanbagabas) in [https://github.com/charmbracelet/bubbletea/pull/1008](https://togithub.com/charmbracelet/bubbletea/pull/1008) - chore(deps): bump golang.org/x/sys from 0.19.0 to 0.20.0 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/charmbracelet/bubbletea/pull/1003](https://togithub.com/charmbracelet/bubbletea/pull/1003) - chore(deps): bump golangci/golangci-lint-action from 5 to 6 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/charmbracelet/bubbletea/pull/1005](https://togithub.com/charmbracelet/bubbletea/pull/1005) - chore(deps): bump golang.org/x/term from 0.19.0 to 0.20.0 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/charmbracelet/bubbletea/pull/1002](https://togithub.com/charmbracelet/bubbletea/pull/1002) **Full Changelog**: charmbracelet/bubbletea@v0.26.1...v0.26.2 *** <a href="https://charm.sh/"><img alt="The Charm logo" src="https://stuff.charm.sh/charm-badge.jpg" width="400"></a> Thoughts? Questions? We love hearing from you. Feel free to reach out on [Twitter](https://twitter.com/charmcli), [The Fediverse](https://mastodon.social/@​charmcli), or [Discord](https://charm.sh/chat). </details> <details> <summary>package-url/packageurl-go (github.com/package-url/packageurl-go)</summary> ### [`v0.1.3`](https://togithub.com/package-url/packageurl-go/releases/tag/v0.1.3) [Compare Source](https://togithub.com/package-url/packageurl-go/compare/v0.1.2...v0.1.3) #### What's Changed - go.mod: Bump required Go version to 1.18 by [@​magnusbaeck](https://togithub.com/magnusbaeck) in [https://github.com/package-url/packageurl-go/pull/66](https://togithub.com/package-url/packageurl-go/pull/66) - Fix Github Actions by [@​shibumi](https://togithub.com/shibumi) in [https://github.com/package-url/packageurl-go/pull/69](https://togithub.com/package-url/packageurl-go/pull/69) - Adds `./` and `../` as valid subpath prefix by [@​ridhoq](https://togithub.com/ridhoq) in [https://github.com/package-url/packageurl-go/pull/68](https://togithub.com/package-url/packageurl-go/pull/68) #### New Contributors - [@​magnusbaeck](https://togithub.com/magnusbaeck) made their first contribution in [https://github.com/package-url/packageurl-go/pull/66](https://togithub.com/package-url/packageurl-go/pull/66) - [@​ridhoq](https://togithub.com/ridhoq) made their first contribution in [https://github.com/package-url/packageurl-go/pull/68](https://togithub.com/package-url/packageurl-go/pull/68) **Full Changelog**: package-url/packageurl-go@v0.1.2...v0.1.3 </details> <details> <summary>grpc/grpc-go (google.golang.org/grpc)</summary> ### [`v1.64.0`](https://togithub.com/grpc/grpc-go/releases/tag/v1.64.0): Release 1.64.0 [Compare Source](https://togithub.com/grpc/grpc-go/compare/v1.63.2...v1.64.0) ### API Changes - stats: Deprecate `InPayload.Data` and `OutPayload.Data`; they were experimental and will be deleted in the next release ([#​7121](https://togithub.com/grpc/grpc-go/issues/7121)) ### Behavior Changes - codec: Remove handling of environment variable `GRPC_GO_ADVERTISE_COMPRESSORS` to suppress setting supported compressors in `grpc-accept-encoding` header. Compressors will always be advertised, as they have been by default for some time ([#​7203](https://togithub.com/grpc/grpc-go/issues/7203)) ### New Features - resolver/dns: Add `SetMinResolutionInterval` to set the minimum interval at which DNS re-resolutions may occur ([#​6962](https://togithub.com/grpc/grpc-go/issues/6962)) - Special Thanks: [@​HomayoonAlimohammadi](https://togithub.com/HomayoonAlimohammadi) - peer/peer: Implement the `fmt.Stringer` interface for pretty printing `Peer`, and - metadata/metadata: Implement the `fmt.Stringer` interface for pretty printing `MD` ([#​7137](https://togithub.com/grpc/grpc-go/issues/7137)) - Special Thanks: [@​AnomalRoil](https://togithub.com/AnomalRoil) ### Performance Improvements - client: Improve RPC performance by reducing work while holding a lock ([#​7132](https://togithub.com/grpc/grpc-go/issues/7132)) ### Bug Fixes - transport/server: Display the proper timeout value when keepalive pings are not ack'd in time ([#​7038](https://togithub.com/grpc/grpc-go/issues/7038)) - Special Thanks: [@​BatmanAoD](https://togithub.com/BatmanAoD) - channelz: Fix bug that was causing the subchannel's target to be unset ([#​7189](https://togithub.com/grpc/grpc-go/issues/7189)) - stats: Fix bug where peer was not set in context when calling stats handler for `OutPayload`, `InPayload`, and `End` ([#​7096](https://togithub.com/grpc/grpc-go/issues/7096)) ### Dependencies - deps: Remove dependency on deprecated `github.com/golang/protobuf` module ([#​7122](https://togithub.com/grpc/grpc-go/issues/7122)) ### Documentation - grpc: Deprecate `WithBlock`, `WithReturnConnectionError`, `FailOnNonTempDialError` which are ignored by `NewClient` ([#​7097](https://togithub.com/grpc/grpc-go/issues/7097)) - Special Thanks: [@​pellared](https://togithub.com/pellared) - grpc: Deprecate `Dial` and `DialContext`. These will continue to be supported throughout 1.x, but are deprecated to direct users to `NewClient` (See [#​7090](https://togithub.com/grpc/grpc-go/issues/7090) for more information) - examples: Add custom lb example ([#​6691](https://togithub.com/grpc/grpc-go/issues/6691)) </details> <details> <summary>protocolbuffers/protobuf-go (google.golang.org/protobuf)</summary> ### [`v1.34.1`](https://togithub.com/protocolbuffers/protobuf-go/releases/tag/v1.34.1) [Compare Source](https://togithub.com/protocolbuffers/protobuf-go/compare/v1.34.0...v1.34.1) Minor fixes for editions compliance: - [CL/582635](https://go.dev/cl/582635): all: update to protobuf 27.0-rc1 and regenerate protos - [CL/582755](https://go.dev/cl/582755): encoding/proto\[json|text]: accept lower case names for group-like fields </details> --- ### Configuration 📅 **Schedule**: Branch creation - "before 6am on monday" in timezone Australia/Sydney, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://togithub.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/google/osv-scanner). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zNTEuMiIsInVwZGF0ZWRJblZlciI6IjM3LjM2My41IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJkZXBlbmRlbmNpZXMiXX0=--> --------- Co-authored-by: Xueqin Cui <72771658+cuixq@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
Just updated to 0.26.1 and noticed that the first line of my UI does not render until an event takes place(keypress, window resize etc). When downgrading to 0.25, everything works correctly, just wondering if something new was introduced/fixed that I need to account for or if this is maybe a regression?
Setup
Please complete the following information along with version numbers, if applicable.
To Reproduce
Steps to reproduce the behavior:
make
Source Code
https://github.com/mistakenelf/fm
Expected behavior
The first line of the UI should render without any actions
Screenshots
Notice that the first line of the filetree and the help screen on the right are not rendering until an action happens
The text was updated successfully, but these errors were encountered: