Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/unit test #44

Merged
merged 9 commits into from
May 28, 2019
Merged

Feature/unit test #44

merged 9 commits into from
May 28, 2019

Conversation

charliegdev
Copy link
Owner

Basic Component Unit Testing

This PR resolves this issue: #41

test-result

The tests we have right now are all very basic:

  • Render test to make sure the component doesn't crash;
  • Snapshot test to make sure the component's appearance isn't accidentally changed.

Right now the tests take about 13 to 16 seconds to finish and that's not ideal. I will solve that later.

@charliegdev charliegdev added bug Something isn't working enhancement New feature or request labels May 28, 2019
@charliegdev charliegdev added this to the MVP milestone May 28, 2019
@charliegdev charliegdev self-assigned this May 28, 2019
@charliegdev charliegdev merged commit 41dd2c1 into master May 28, 2019
@charliegdev charliegdev deleted the feature/unit-test branch May 28, 2019 05:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant