Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adopt Yarn workspaces/lerna and separate out the demo and library "proper" #50

Merged
merged 71 commits into from
Apr 7, 2022

Conversation

charlie-yao
Copy link
Owner

@charlie-yao charlie-yao commented Feb 24, 2022

  • Adopt a monorepo approach by using yarn workspaces and lerna
  • Separate the repo into two yarn workspaces/lerna packages - react-aria-widgets for the library "proper" and react-aria-widgets-demo one for the demo/docs website
  • Begin using React Storybook on the accordion components in react-aria-widgets
  • Webpack config changes
    • separate dev and prod configs
    • begin splitting up code into separate chunks
  • Misc. changes, e.g.:
    • ESLint config modifications

Resolves #11
Related to #8, #9

https://yarnpkg.com/features/workspaces
https://github.com/lerna/lerna
https://mytechblog.io/lerna-yarn-workspaces
https://leerob.io/blog/monorepo-lerna-yarn-workspaces
https://verdaccio.org/blog/2019/09/07/managing-multiples-projects-with-lerna-and-yarn-workspaces/
https://www.honeybadger.io/blog/monorepo-yarn-workspace-lerna/

=========================

Note: added core-js as a dev dependency in the root workspace because it fixes an issue where react-storybook complains:

ERR! Error: @storybook/addon-interactions tried to access core-js, but it isn't declared in its dependencies; this makes the require call ambiguous and unsound.    

There's probably a better fix or workaround somewhere in storybookjs/storybook#11255, but this one seems to work well-enough and doesn't seem to add extra clutter to PnP cache.

@charlie-yao charlie-yao changed the title Webpack Config Updates Adopt Yarn workspaces/lerna and separate out the demo and library "proper" Mar 23, 2022
@charlie-yao charlie-yao merged commit 4fbb87f into develop Apr 7, 2022
@charlie-yao charlie-yao mentioned this pull request Sep 13, 2022
@charlie-yao charlie-yao deleted the feature/libraryBuild branch August 24, 2023 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Separate webpack builds
1 participant