Allow setting queue for each job #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devilankur18
changed the title
|
Hey @devilankur18, thanks for the PR! Before we merge this can you clean up the unrelated changes you copied from here? aeris@c9f9d92 |
pokonski
requested changes
Aug 13, 2018
lib/gush/job.rb
Outdated
| attr_reader :name, :output_payload, :params | ||
|
|
||
| def initialize(opts = {}) | ||
| options = opts.dup | ||
| assign_variables(options) | ||
| end | ||
|
|
||
| def payload(clazz) |
There was a problem hiding this comment.
Please remove this method, it's not related and not needed
lib/gush/job.rb
Outdated
| @@ -98,6 +105,9 @@ def has_no_dependencies? | |||
| end | |||
|
|
|||
| private | |||
| def logger | |||
lib/gush/worker.rb
Outdated
| client.enqueue_job(workflow_id, out) | ||
| end | ||
| out | ||
| end | ||
| rescue RedisMutex::LockError |
|
@pokonski updated !! |
pokonski
approved these changes
Aug 14, 2018
|
Looks good! Can you also fix the one failing spec and I'll merge it :) Thanks! |
|
@pokonski fixed !! |
|
@devilankur18 this is now released under version 2.0.0. Thanks again and sorry for the delay! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#39 Added queue support as per the latest code.