Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update version in build workflow based on rlease tag #78

Merged
merged 3 commits into from
Aug 31, 2024

Conversation

Monirzadeh
Copy link
Contributor

@Monirzadeh Monirzadeh commented Aug 30, 2024

fix #77
get tag when run build workflow and update version in desktop entry

in my local test it is work please test that in github side too
should i automatically drop v in the beginning of tag as i see you always tag like this v0.2.6

Copy link
Collaborator

@mirzakhany mirzakhany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for PR, 'chapar.desktop' its only required for linux build. please remove it from other actions

@ccoVeille
Copy link
Contributor

Nitpick: typo in the PR title with the word "release"

The commit message seems OK

@Monirzadeh Monirzadeh requested a review from mirzakhany August 31, 2024 11:01
@mirzakhany mirzakhany merged commit a39658e into chapar-rest:main Aug 31, 2024
2 checks passed
@Monirzadeh Monirzadeh deleted the fix-version-desktop-entty branch August 31, 2024 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Release not update version in desktop entry
3 participants