Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[graal] Add configuration for Graal integration in ELK #320

Merged
merged 2 commits into from
Aug 23, 2019

Conversation

inishchith
Copy link
Contributor

@inishchith inishchith commented Aug 10, 2019

  • Added the configuration required to trigger enricher and study integration of Graal from ELK.

Note: The tests would fail until we merge chaoss/grimoirelab-elk#672

/cc @valeriocos

Signed-off-by: inishchith inishchith@gmail.com

Copy link
Member

@valeriocos valeriocos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR @inishchith , please consider to include the code shared at chaoss/grimoirelab-sigils#380 (comment)

@inishchith
Copy link
Contributor Author

@valeriocos Sure. I'm just finishing up with the scancode-cli task. This along with sigils#PR should be updated in next hour.
Sorry for the delay

@valeriocos
Copy link
Member

valeriocos commented Aug 16, 2019

no worries, thanks for the quick reply

@inishchith
Copy link
Contributor Author

@valeriocos Thanks for all the help.
I've included the code references from chaoss/grimoirelab-elk#672 after testing them on entire toolchain

@valeriocos
Copy link
Member

you're welcome :)

Copy link
Member

@valeriocos valeriocos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @inishchith

@valeriocos
Copy link
Member

@sduenas feel free to have a look at it

Copy link
Member

@sduenas sduenas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I couldn't test it but it looks good to me. @valeriocos if you tested it and you're confident this doesn't cause any problem, we can merge it.

@inishchith inishchith force-pushed the graal_integration_config branch 3 times, most recently from 15d5956 to 2d8058e Compare August 23, 2019 15:16
@coveralls
Copy link

coveralls commented Aug 23, 2019

Pull Request Test Coverage Report for Build 864

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 141 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.02%) to 55.504%

Files with Coverage Reduction New Missed Lines %
/home/travis/build/chaoss/grimoirelab-sirmordred/sirmordred/config.py 29 77.4%
/home/travis/build/chaoss/grimoirelab-sirmordred/sirmordred/task_panels.py 112 58.82%
Totals Coverage Status
Change from base Build 859: -0.02%
Covered Lines: 1195
Relevant Lines: 2153

💛 - Coveralls

Signed-off-by: inishchith <inishchith@gmail.com>
Signed-off-by: inishchith <inishchith@gmail.com>
@inishchith inishchith force-pushed the graal_integration_config branch from f177abb to 9a2746d Compare August 23, 2019 16:25
@valeriocos valeriocos merged commit efe86a7 into chaoss:master Aug 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants