[remo] Support offset in the cache #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sduenas
requested changes
Dec 12, 2016
… upstream and from cache
|
@sduenas offset tests added |
sduenas
approved these changes
Dec 14, 2016
sduenas
requested changes
Dec 14, 2016
… the previous one.
sduenas
approved these changes
Dec 14, 2016
valeriocos
pushed a commit
to valeriocos/perceval-mozilla
that referenced
this pull request
Feb 22, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now in the perceval cache for remo the offset was not stored so items recovered from the cache have not the offset field. This patch fix it with the same approach than kitsune.