-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[cloc] Fix cloc error due to mulitple word language-name #46
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @inishchith for the PR. It looks good, I have just a couple of minor comments.
- Could you increase the version number of the cloc analyzer?
- It would be possible to add some assertions to the existing tests (test_cloc.py) to be sure we are correctly parsing
blanks
,comments
andloc
?
Sure. Done!
It's possible by implementing the same logic at the test side. I'll add it, Please let me know if there's a better way of doing it. Thanks! |
Thanks
I apologize for being unclear. I meant to do something like:
|
This commit fixes error produced due to language names with multiple words Signed-off-by: inishchith <inishchith@gmail.com>
@valeriocos No worries. Thanks for the clarification! I've made the changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @inishchith
@valeriocos As I was working on large repository evaluation(inishchith/gsoc#12 (comment)), enter this error in logic under
cloc
analyzer which depends on reporting of results based on position in the list.This PR fixes the error by picking the elements from the last(right to left). Please let me know what you think :)
Signed-off-by: inishchith inishchith@gmail.com