Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[elk] Add option to fetch from selected branches #650

Merged
merged 1 commit into from
Jul 3, 2019

Conversation

inishchith
Copy link
Contributor

@inishchith inishchith commented Jun 30, 2019

Fixes: #642

@jgbarah @valeriocos Please do have a look, let me know if any changes required.

Thanks!

TODO:

  • Add tests (if needed)
  • Update docstrings

Signed-off-by: inishchith inishchith@gmail.com

Signed-off-by: inishchith <inishchith@gmail.com>
@inishchith inishchith force-pushed the select_branch_option branch from cfc55ed to d0d1edb Compare June 30, 2019 05:52
@coveralls
Copy link

Pull Request Test Coverage Report for Build 1512

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 216 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.1%) to 68.218%

Files with Coverage Reduction New Missed Lines %
/home/travis/build/chaoss/grimoirelab-elk/grimoire_elk/raw/elastic.py 16 43.31%
/home/travis/build/chaoss/grimoirelab-elk/grimoire_elk/elk.py 200 11.71%
Totals Coverage Status
Change from base Build 1510: -0.1%
Covered Lines: 5628
Relevant Lines: 8250

💛 - Coveralls

@valeriocos
Copy link
Member

Thank you @inishchith for the PR, do you plan to add tests? I can have a look at the code and help you with this.

@inishchith
Copy link
Contributor Author

@valeriocos I'll add the tests and ping you back.

Thanks!

@inishchith
Copy link
Contributor Author

@valeriocos Sorry, I'm not sure if tests could be added as we do not have tests covering the ocean_backend.feed() method. Please do correct me in case I missed something.

@valeriocos
Copy link
Member

No worries, @inishchith I'll have a look and see if we can add some tests

@valeriocos
Copy link
Member

It isn't straightforward to add tests since the code should be refactored.

@valeriocos valeriocos self-requested a review July 2, 2019 15:50
Copy link
Member

@valeriocos valeriocos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @inishchith

@valeriocos
Copy link
Member

@sduenas I tested the PR and it works fine.

The change is similar to the one to include the filter-classified param (210e877), so we shouldn't have surprises.

Tests cannot be easily added because the code should be refactored. If you agree we can give it a try otherwise the PR can be accepted as it is.

Copy link
Member

@sduenas sduenas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Let's merge it.

@valeriocos valeriocos merged commit d7cc72a into chaoss:master Jul 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add option to fetch from selected branches
4 participants