Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Body Compression Issue Fix #4

Merged
merged 3 commits into from
Sep 1, 2022
Merged

Body Compression Issue Fix #4

merged 3 commits into from
Sep 1, 2022

Conversation

avaakash
Copy link
Member

@avaakash avaakash commented Sep 1, 2022

This PR fixes an issue where the response was not getting read by the browser because of a compression type mismatch. Added deflate and gzip compression algorithms and an option to provide the content_encoding in both modify-body and status_code. Also added content-type in both.

Signed-off-by: Akash Shrivastava <akash.shrivastava@harness.io>
…odify-fix

Signed-off-by: Akash Shrivastava <akash.shrivastava@harness.io>
Signed-off-by: Akash Shrivastava <akash.shrivastava@harness.io>
@avaakash avaakash self-assigned this Sep 1, 2022
Copy link
Collaborator

@Jonsy13 Jonsy13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good!!

@avaakash avaakash merged commit cc9259c into master Sep 1, 2022
@avaakash avaakash deleted the body-modify-fix branch March 1, 2023 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants