Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: upgrade gopsutil to make it available at darwin/arm64 #55

Merged

Conversation

spencercjh
Copy link
Contributor

@spencercjh spencercjh commented Mar 11, 2024

Describe what this PR does / why we need it

The current older version of github.com/shirou/gopsutil leads make failed at darwin/arm64, maybe also failed at linux/arm64 in repo chaosblade-io/chaosblade-exec-cplus.

Does this pull request fix one issue?

Part of chaosblade-io/chaosblade#1010, and there will be another PR in exec-cplus to resolve it at all.

Describe how you did it

  • fix: Upgrade github.com/shirou/gopsutil to the latest version and tidy go mod;
  • chore: gofmt two files.

Describe how to verify it

I use codes at test branch https://github.com/spencercjh/chaosblade-spec-go/tree/456 to replace
the previous spec-go.

image

And I got a success to make.

image

Here is the new exec-cplus: https://github.com/spencercjh/chaosblade-exec-cplus/tree/test/replace-spec-go

Special notes for reviews

This PR has included #56 to make it build pass.

RESOLVE #56

… silicon

Signed-off-by: spencercjh <spencercjh@gmail.com>
@MandssS MandssS added this to the v1.7.4 milestone Jul 1, 2024
@MandssS MandssS merged commit 62f73c4 into chaosblade-io:master Jul 1, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants