Dem renamed restart application tests + parameter file generator #1402
Conversation
|
@OGaboriault I think you messed up the file path for the moving_receptacle mesh |
| @@ -1,2 +1,2 @@ | |||
| version nproc n_attached_fixed_size_objs n_attached_variable_size_objs n_coarse_cells | |||
| 5 16 0 1 5 | |||
| 5 1 0 1 5 | |||
There was a problem hiding this comment.
Funny it means the previous restart was made with 16 procs, why? I don't know...
This could explain the results change. Anyway it's good the way you did it.
There was a problem hiding this comment.
There's not a lot of us with a 16 procs computer who are working on the DEM. I wonder who did this. (Probably me, hehe)
| Time 0.5 | ||
| Iter 10000 |
There was a problem hiding this comment.
It's not a big deal that you changed it. Glad we are making this in another PR though otherwise would be confusing
There was a problem hiding this comment.
I didn't changed it intentionally. The checkpoint frequency of the generator was already set so that the last checkpoint occurs at 0.5
…ter, we know its fine
…for the restart files for the circle test
OGaboriault
force-pushed
the
dem_renamed_restart_app_tests
branch
from
16c5a1f to
34292d0
Compare
Description While refactoring the DEM, I realized that many tests were using the prefix restart_ and other were using the suffix _restart, which is not coherent. Also, some test using restarts didn't have a parameter file generator and some generator weren't working correctly since the implementation of the double restart feature. Solution Some application tests were renamed following the restart_ prefix All generator file were tested. Because of this, some file were renamed/modified and some results changed. Missing generator files were created. Co-authored-by: Bruno Blais <blais.bruno@gmail.com>
Description
While refactoring the DEM, I realized that many tests were using the prefix restart_ and other were using the suffix _restart, which is not coherent. Also, some test using restarts didn't have a parameter file generator and some generator weren't working correctly since the implementation of the double restart feature.
Solution
Testing
N/A ...
Documentation
N/A
Miscellaneous (will be removed when merged)
When using the generator files, the user should "git clean -f" afterwards so that the other version of the restart files are removed automatically.
Checklist (will be removed when merged)
See this page for more information about the pull request process.
Code related list:
Pull request related list: