Update flow past a backward facing step example #1389

lpsaavedra · 2024-11-27T15:39:29Z

Description

The post-processing scripts were not working for this example and the example was long and hard to follow. This PR refactors the example by limiting it to two Reynolds numbers: 100 and 1000. To summarize:

All the parameters are revisited to ensure correct convergence for both cases.
The folders and parameter files are renamed so that it is clear for which Reynolds they are.
The results are limited to: visualizing the velocity profiles (with streamlines to identify eddy after step and zoom in plots, all in one figure), reporting the reattachment point for the last step and its relative error in comparison to reference data, and comparing the obtained velocity distribution at the outlet to the analytical solution.
The post-processing scripts are fixed so that they work for both Reynolds number by just changing the appropriate flag when running the script. Moreover, the number of vtu files is no longer hardcoded and can be found automatically by the script.

Checklist (will be removed when merged)

See this page for more information about the pull request process.

Code related list:

Lethe documentation is up to date
Copyright headers are present and up to date
The branch is rebased onto master
Code is indented with indent-all and .prm files (examples and tests) with prm-indent
Links are added to parent .rst files
The example is following the standard format

Pull request related list:

Labels are applied
There are at least 2 reviewers (or 1 if small feature) excluding the responsible for the merge
The PR description is cleaned and ready for merge

voferreira

Nice images! All clear. I added small suggestions but nothing fancy.

doc/source/examples/incompressible-flow/2d-backward-facing-step/2d-backward-facing-step.rst

voferreira · 2024-11-27T18:26:48Z

doc/source/examples/incompressible-flow/2d-backward-facing-step/image/Reynolds1000_profile.png

voferreira · 2024-11-27T18:26:58Z

doc/source/examples/incompressible-flow/2d-backward-facing-step/image/Reynolds100_profile.png

Lovely! (1)

Co-authored-by: Victor Oliveira Ferreira <voferreira@outlook.com>

OGaboriault · 2024-11-27T19:32:27Z

doc/source/examples/incompressible-flow/2d-backward-facing-step/2d-backward-facing-step.rst

+- Parameter file for the base case (:math:`\mathrm{Re} = 100`): ``Reynolds100_steady.prm``
+- Parameter file for the higher-Reynolds case (:math:`\mathrm{Re} = 1000`): ``Reynolds1000_steadybdf.prm``


the two prm file should end with or without bfd at the end.

no I think this is fine right now no?

The reason for this is that both cases are solved differently (see simulation control section). The Reynolds 100 case is solved as a steady problem, while the second one uses steady bdf.

doc/source/examples/incompressible-flow/2d-backward-facing-step/2d-backward-facing-step.rst

OGaboriault · 2024-11-27T20:00:20Z

doc/source/examples/incompressible-flow/2d-backward-facing-step/2d-backward-facing-step.rst


+For the case where :math:`\textrm{Re}=1000`, replace the name of the parameter file by ``Reynolds1000_steadybdf.prm``.


same thing here, with or without the bfd

nah I think this is ok right now. Because steadybdf is the name of the method

blaisb

One tiny typo, then ready for merge

blaisb · 2024-11-27T20:22:35Z

doc/source/examples/incompressible-flow/2d-backward-facing-step/2d-backward-facing-step.rst

+- Parameter file for the base case (:math:`\mathrm{Re} = 100`): ``Reynolds100_steady.prm``
+- Parameter file for the higher-Reynolds case (:math:`\mathrm{Re} = 1000`): ``Reynolds1000_steadybdf.prm``


no I think this is fine right now no?

doc/source/examples/incompressible-flow/2d-backward-facing-step/2d-backward-facing-step.rst

blaisb · 2024-11-27T20:24:28Z

doc/source/examples/incompressible-flow/2d-backward-facing-step/2d-backward-facing-step.rst


+For the case where :math:`\textrm{Re}=1000`, replace the name of the parameter file by ``Reynolds1000_steadybdf.prm``.


nah I think this is ok right now. Because steadybdf is the name of the method

lpsaavedra · 2024-11-27T20:25:26Z

Thank you for your review, I have applied all the comments and I will mark this as ready to merge :)

lpsaavedra added 14 commits November 27, 2024 10:36

Update parameter files and example images

5403dd2

Add boundary condition ID

e43cd42

Change kinematic viscosity to have Re 100

bb7259c

Update images and reduce example to only two Reynolds numbers

bc106a9

Rename folders

c3c7f32

Rename parameter files

f0e7869

Update name of parameter file on doc

10d600f

Change viscosity for Re 1000

451ce1d

Minor changes to doc

5b172f8

Update velocity distribution script

c62e978

Remove reattachment plots and only mention final result

9940f18

Rename script

7e08356

Update scripts

2515ae5

Delete reattachment plots

9aafa2a

lpsaavedra added Ready for review Example Next release PR that would need to be merged before the next release labels Nov 27, 2024

lpsaavedra requested a review from voferreira November 27, 2024 18:13

voferreira approved these changes Nov 27, 2024

View reviewed changes

lpsaavedra and others added 3 commits November 27, 2024 13:48

Apply suggestions from code review

1f0b5df

Co-authored-by: Victor Oliveira Ferreira <voferreira@outlook.com>

Apply further suggestions and delete outdated sentence

9ae658c

Remove unused references

95bc52e

OGaboriault approved these changes Nov 27, 2024

View reviewed changes

Minor corrections after review

dad51a0

blaisb approved these changes Nov 27, 2024

View reviewed changes

Correct minor typo

3051cbe

blaisb merged commit 8977e0a into master Nov 27, 2024
4 checks passed

blaisb deleted the update_backward_step branch November 27, 2024 20:27

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update flow past a backward facing step example #1389

Update flow past a backward facing step example #1389

lpsaavedra commented Nov 27, 2024 •

edited

Loading

voferreira left a comment

voferreira Nov 27, 2024

voferreira Nov 27, 2024

OGaboriault Nov 27, 2024

blaisb Nov 27, 2024

lpsaavedra Nov 27, 2024

OGaboriault Nov 27, 2024

blaisb Nov 27, 2024

blaisb left a comment

blaisb Nov 27, 2024

blaisb Nov 27, 2024

lpsaavedra commented Nov 27, 2024

		- Parameter file for the base case (:math:`\mathrm{Re} = 100`): ``Reynolds100_steady.prm``
		- Parameter file for the higher-Reynolds case (:math:`\mathrm{Re} = 1000`): ``Reynolds1000_steadybdf.prm``


		For the case where :math:`\textrm{Re}=1000`, replace the name of the parameter file by ``Reynolds1000_steadybdf.prm``.

Update flow past a backward facing step example #1389

Update flow past a backward facing step example #1389

Conversation

lpsaavedra commented Nov 27, 2024 • edited Loading

Description

Checklist (will be removed when merged)

voferreira left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

blaisb left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lpsaavedra commented Nov 27, 2024

lpsaavedra commented Nov 27, 2024 •

edited

Loading