Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test without void fraction bounding #1386

Merged
merged 2 commits into from
Nov 25, 2024
Merged

Conversation

blaisb
Copy link
Contributor

@blaisb blaisb commented Nov 25, 2024

Description

As part of the current void fraction refactoring I wish to aim at deprecating the void fraction bounding after the refactoring is done. This requires modifying the test that currently use void fraction bounds. This PR updates the tests that use lethe-fluid-vans to not bound the void fraction. This is all it does, update the tests.

Testing

Test results are updated.

Documentation

Nothing to be done here

Miscellaneous (will be removed when merged)

Checklist (will be removed when merged)

See this page for more information about the pull request process.

Code related list:

  • All in-code documentation related to this PR is up to date (Doxygen format)
  • Copyright headers are present and up to date
  • Lethe documentation is up to date
  • The branch is rebased onto master
  • Code is indented with indent-all and .prm files (examples and tests) with prm-indent
  • If parameters are modified, the tests and the documentation of examples are up to date
  • Changelog (CHANGELOG.md) is up to date if the refactor affects the user experience or the codebase

Pull request related list:

  • No other PR is open related to this refactoring
  • Labels are applied
  • There are at least 2 reviewers (or 1 if small feature) excluding the responsible for the merge
  • If this PR closes an issue or is related to a project, it is linked in the "Projects" or "Development" section
  • If any future works is planned, an issue is opened
  • The PR description is cleaned and ready for merge

@blaisb blaisb added Reviewed and ready to merge Rebased Refactoring This PR is only refactoring or clean up labels Nov 25, 2024
@blaisb blaisb merged commit b921fcf into master Nov 25, 2024
11 checks passed
@blaisb blaisb deleted the test_without_void_fraction_bounding branch November 25, 2024 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Rebased Refactoring This PR is only refactoring or clean up Reviewed and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant