Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cylindrical packed bed #1369

Merged
merged 8 commits into from
Nov 21, 2024
Merged

Cylindrical packed bed #1369

merged 8 commits into from
Nov 21, 2024

Conversation

blaisb
Copy link
Contributor

@blaisb blaisb commented Nov 18, 2024

Description

The steady-state flow withing a cylindrical packed bed example was working fine, but the documentation was outdated. Furthermore, the figures we atrociously bad and were not representative enough. I have updated the example results and I have added new figures which illustrate the behavior of the VANS equation in a better fashion. I have also added a simple python post-processing script to do these calculations.

Code related list:

  • Lethe documentation is up to date
  • Copyright headers are present and up to date
  • The branch is rebased onto master
  • Code is indented with indent-all and .prm files (examples and tests) with prm-indent
  • Links are added to parent .rst files
  • The example is following the standard format

Pull request related list:

  • Labels are applied
  • There are at least 2 reviewers (or 1 if small feature) excluding the responsible for the merge
  • If this PR closes an issue or is related to a project, it is linked in the "Projects" or "Development" section
  • If any future works is planned, an issue is opened
  • The PR description is cleaned and ready for merge

@blaisb blaisb added Documentation Ready for review Next release PR that would need to be merged before the next release labels Nov 18, 2024
Copy link
Collaborator

@lpsaavedra lpsaavedra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments/questions from my side, but seems good already

blaisb and others added 2 commits November 21, 2024 10:33
…cylindrical-packed-bed.rst

Co-authored-by: Laura Prieto Saavedra <40216050+lpsaavedra@users.noreply.github.com>
@blaisb blaisb merged commit cbb0d94 into master Nov 21, 2024
4 checks passed
@blaisb blaisb deleted the cylindrical_packed_bed branch November 21, 2024 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Next release PR that would need to be merged before the next release Reviewed and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants