Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove DEM warnings #1267

Merged
merged 3 commits into from
Aug 28, 2024
Merged

Remove DEM warnings #1267

merged 3 commits into from
Aug 28, 2024

Conversation

blaisb
Copy link
Contributor

@blaisb blaisb commented Aug 27, 2024

Description

In my endless aim for no clang tidy warnings, this PR cleans the warning for the DEM part of the library. There should not be th

Code related list:

  • All in-code documentation related to this PR is up to date (Doxygen format)
  • Lethe documentation is up to date
  • The branch is rebased onto master
  • Code is indented with indent-all and .prm files (examples and tests) with prm-indent
  • If parameters are modified, the tests and the documentation of examples are up to date
  • Changelog (CHANGELOG.md) is up to date if the refactor affects the user experience or the codebase

Pull request related list:

  • No other PR is open related to this refactoring
  • Labels are applied
  • There are at least 2 reviewers (or 1 if small feature) excluding the responsible for the merge
  • If this PR closes an issue or is related to a project, it is linked in the "Projects" or "Development" section
  • If any future works is planed, an issue is opened
  • The PR description is cleaned and ready for merge

@blaisb blaisb added the WIP When a PR is open but not ready for review label Aug 27, 2024
@blaisb blaisb force-pushed the remove_dem_warnings branch from 30b6ca7 to d99607a Compare August 27, 2024 18:55
@blaisb blaisb removed the WIP When a PR is open but not ready for review label Aug 27, 2024
@blaisb blaisb changed the title [WIP] Remove DEM warnings Remove DEM warnings Aug 27, 2024
@oguevremont oguevremont self-requested a review August 28, 2024 13:03
@blaisb blaisb merged commit 08fcd76 into master Aug 28, 2024
10 of 11 checks passed
@blaisb blaisb deleted the remove_dem_warnings branch August 28, 2024 14:52
M-Badri pushed a commit to M-Badri/lethe that referenced this pull request Sep 29, 2024
@blaisb
Remove DEM warnings (chaos-polymtl#1267)
d395308 
Description
In my endless aim for no clang tidy warnings, this PR cleans the warning for the DEM part of the library. There should not be any changes to the tests (there are no changes)

Former-commit-id: 08fcd76
blaisb added a commit that referenced this pull request Sep 30, 2024
@blaisb
Remove DEM warnings (#1267)
1f3d7ca 
Description
In my endless aim for no clang tidy warnings, this PR cleans the warning for the DEM part of the library. There should not be any changes to the tests (there are no changes)

Former-commit-id: 08fcd76
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oguevremont oguevremont oguevremont approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@blaisb @oguevremont