Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify GMRES parameters whent iterating intermediate GMG levels #1264

Merged
merged 2 commits into from
Aug 27, 2024

Conversation

lpsaavedra
Copy link
Collaborator

Description

In PR #1211 a new parameter was introduced that allow to iterate intermediate GMG levels. This allows to choose a level as coarse grid and used there a GMRES iterative solver preconditioned by a MG. So far, only one parameter was present: mg int level, however, the parameters for the number of iterations and tolerances were being hardcoded. This PR changes that by using already existing GMRES parameters..

Testing

I have tested this in the flow around a sphere case and seems to work just fine.

Documentation

The documentation was updated by adding a note that specifies the use of these parameters for this purpose as well.

Checklist (will be removed when merged)

See this page for more information about the pull request process.

Code related list:

  • All in-code documentation related to this PR is up to date (Doxygen format)
  • Lethe documentation is up to date
  • The branch is rebased onto master
  • Code is indented with indent-all and .prm files (examples and tests) with prm-indent

Pull request related list:

  • Labels are applied
  • There are at least 2 reviewers (or 1 if small feature) excluding the responsible for the merge
  • If this PR closes an issue or is related to a project, it is linked in the "Projects" or "Development" section
  • The PR description is cleaned and ready for merge

@lpsaavedra lpsaavedra changed the title Add int parameters Specify GMRES parameters whent iterating intermediate GMG levels Aug 27, 2024
@lpsaavedra lpsaavedra requested a review from peterrum August 27, 2024 12:27
@lpsaavedra lpsaavedra self-assigned this Aug 27, 2024
this->coarse_grid_solver_control_intermediate =
std::make_shared<ReductionControl>(1000, 1e-20, 1e-2, false, false);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lpsaavedra Don't forget to set these parameters in the new parameter files!

@blaisb blaisb merged commit bf39a0d into master Aug 27, 2024
10 of 11 checks passed
@blaisb blaisb deleted the add_int_parameters branch August 27, 2024 15:27
M-Badri pushed a commit to M-Badri/lethe that referenced this pull request Sep 29, 2024
…os-polymtl#1264)

Description
In PR chaos-polymtl#1211 a new parameter was introduced that allow to iterate intermediate GMG levels. This allows to choose a level as coarse grid and used there a GMRES iterative solver preconditioned by a MG. So far, only one parameter was present: mg int level, however, the parameters for the number of iterations and tolerances were being hardcoded. This PR changes that by using already existing GMRES parameters..

Testing
I have tested this in the flow around a sphere case and seems to work just fine.

Documentation
The documentation was updated by adding a note that specifies the use of these parameters for this purpose as well.

Former-commit-id: bf39a0d
blaisb pushed a commit that referenced this pull request Sep 30, 2024
Description
In PR #1211 a new parameter was introduced that allow to iterate intermediate GMG levels. This allows to choose a level as coarse grid and used there a GMRES iterative solver preconditioned by a MG. So far, only one parameter was present: mg int level, however, the parameters for the number of iterations and tolerances were being hardcoded. This PR changes that by using already existing GMRES parameters..

Testing
I have tested this in the flow around a sphere case and seems to work just fine.

Documentation
The documentation was updated by adding a note that specifies the use of these parameters for this purpose as well.

Former-commit-id: bf39a0d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants