Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update print parameters for prototype #1260

Merged
merged 1 commit into from
Aug 26, 2024
Merged

Update print parameters for prototype #1260

merged 1 commit into from
Aug 26, 2024

Conversation

lpsaavedra
Copy link
Collaborator

@lpsaavedra lpsaavedra commented Aug 26, 2024 •
edited
Loading

Description

The prototypes were not compiling due to print_parameters call. Following commit 1fa5306, the print parameters call for the matrix-based non linear poisson prototype is corrected.

Checklist (will be removed when merged)

See this page for more information about the pull request process.

Code related list:

  • The branch is rebased onto master
  • Code is indented with indent-all and .prm files (examples and tests) with prm-indent

Pull request related list:

  • Labels are applied
  • There are at least 2 reviewers (or 1 if small feature) excluding the responsible for the merge
  • The PR description is cleaned and ready for merge

@lpsaavedra lpsaavedra requested a review from blaisb August 26, 2024 14:48
@lpsaavedra lpsaavedra added the Bug Something isn't working label Aug 26, 2024
@lpsaavedra lpsaavedra mentioned this pull request Aug 26, 2024
Merged
5 tasks
@blaisb blaisb merged commit f7197cf into master Aug 26, 2024
10 of 11 checks passed
@blaisb blaisb deleted the fix_print_params branch August 26, 2024 17:32
M-Badri pushed a commit to M-Badri/lethe that referenced this pull request Sep 29, 2024
@lpsaavedra
Update print parameters for prototype (chaos-polymtl#1260)
abd87db 
Description
The prototypes were not compiling due to print_parameters call. Following commit 1fa5306, the print parameters call for the matrix-based non linear poisson prototype is corrected.



Former-commit-id: f7197cf
blaisb pushed a commit that referenced this pull request Sep 30, 2024
@lpsaavedra
Update print parameters for prototype (#1260)
0295563 
Description
The prototypes were not compiling due to print_parameters call. Following commit 1fa5306, the print parameters call for the matrix-based non linear poisson prototype is corrected.



Former-commit-id: f7197cf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterrum peterrum peterrum approved these changes

@blaisb blaisb blaisb approved these changes

Assignees
No one assigned
Labels
Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lpsaavedra @blaisb @peterrum