Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Different improvements for AMS #1253

Merged
merged 6 commits into from
Aug 23, 2024
Merged

Different improvements for AMS #1253

merged 6 commits into from
Aug 23, 2024

Conversation

peterrum
Copy link
Collaborator

  • setup: compute weights during initialization and convert indices from global to local
  • add timers
  • reused smoother preconditioner instances

@peterrum peterrum requested a review from lpsaavedra August 20, 2024 21:06
blaisb
blaisb requested changes Aug 22, 2024
View reviewed changes
Copy link
Contributor

@blaisb blaisb left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few things to fix. Please try to use one of the PR templates when making a PR. This will make it a bit easier to follow the outcomes of the PR :) .

source/solvers/fluid_dynamics_matrix_free.cc Outdated Show resolved Hide resolved
source/solvers/fluid_dynamics_matrix_free.cc Outdated Show resolved Hide resolved
source/solvers/fluid_dynamics_matrix_free.cc Show resolved Hide resolved
source/solvers/fluid_dynamics_matrix_free.cc Outdated Show resolved Hide resolved
@peterrum
Copy link
Collaborator Author

@blaisb Ready from my side!

blaisb
blaisb approved these changes Aug 23, 2024
View reviewed changes
Copy link
Contributor

@blaisb blaisb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome. I rebased. Will merge after CI.

@blaisb blaisb merged commit 8767433 into master Aug 23, 2024
10 of 11 checks passed
@blaisb blaisb deleted the asm_additions branch August 23, 2024 17:28
M-Badri pushed a commit to M-Badri/lethe that referenced this pull request Sep 29, 2024
@peterrum
Different improvements for AMS (chaos-polymtl#1253)
cba328e 
setup: compute weights during initialization and convert indices from global to local
add timers
reused smoother preconditioner instances
Former-commit-id: 8767433
blaisb pushed a commit that referenced this pull request Sep 30, 2024
@peterrum
Different improvements for AMS (#1253)
c63815c 
setup: compute weights during initialization and convert indices from global to local
add timers
reused smoother preconditioner instances
Former-commit-id: 8767433
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpsaavedra lpsaavedra lpsaavedra approved these changes

@blaisb blaisb blaisb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@peterrum @blaisb @lpsaavedra