Add prototypes flag to warnings CI #1250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterrum
approved these changes
Aug 19, 2024
|
Are you sure you want to compile the prototype for all CI instances? I don't mind that, but it seems like a lot of extra compilation on all instances. :) In all cases, I have rebased your branch |
blaisb
force-pushed
the
add_prototypes_ci
branch
from
5530dad to
c5457b4
Compare
lpsaavedra
changed the title
|
Well now that you say it... it might be a bit too much, so we can leave them only in the warnings CI. I think it will help us to avoid having broken prototypes at some point |
|
It seems that we cannot support both 9.5 and master version of deal.II... do we want to switch to 9.6 some time soon? |
|
@lpsaavedra see #1251 . Once it is merged we can rebase and try again this branch. |
|
@lpsaavedra you just need to rebase and we should be good |
lpsaavedra
force-pushed
the
add_prototypes_ci
branch
from
1316f61 to
0a75bfd
Compare
|
Okay, it seems to be good to go now :) |
M-Badri
pushed a commit
to M-Badri/lethe
that referenced
this pull request
Sep 29, 2024
Description Add prototypes compilation to ensure that they are all up to date. Follow up on PR chaos-polymtl#1249. Former-commit-id: f7e869a
blaisb
pushed a commit
that referenced
this pull request
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add prototypes compilation to ensure that they are all up to date. Follow up on PR #1249.
Checklist (will be removed when merged)
See this page for more information about the pull request process.
Code related list:
Pull request related list: