Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There were some asserts being thrown in debug mode. These asserts were all warrented.
They were cuased by the following:
1- std::shared_ptr cannot be created from a nullptr. Since the sharp edge in the tracer relies on this mechanism to assess if there is or not a shape, this was highly problematic. @oguevremont we will need to look more into this and refactor this more cleanly in the next month. I have made a solution using regular pointers which is fine, but relying on nullptr is not very nice in my opinion
2- There was an std::vector that was not used correctly in the find cell around flat mechanism
3- In the restart for sharp edge, the order of the checks was not done in the right order which violated the size issue.
Solution
Fixed all of those bugs.
Testing
Debug tests should pass now.
Code related list:
Pull request related list: