Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debug ci fix #1247

Merged
merged 4 commits into from
Aug 18, 2024
Merged

Debug ci fix #1247

merged 4 commits into from
Aug 18, 2024

Conversation

blaisb
Copy link
Contributor

@blaisb blaisb commented Aug 18, 2024

Description

There were some asserts being thrown in debug mode. These asserts were all warrented.
They were cuased by the following:
1- std::shared_ptr cannot be created from a nullptr. Since the sharp edge in the tracer relies on this mechanism to assess if there is or not a shape, this was highly problematic. @oguevremont we will need to look more into this and refactor this more cleanly in the next month. I have made a solution using regular pointers which is fine, but relying on nullptr is not very nice in my opinion
2- There was an std::vector that was not used correctly in the find cell around flat mechanism
3- In the restart for sharp edge, the order of the checks was not done in the right order which violated the size issue.

Solution

Fixed all of those bugs.

Testing

Debug tests should pass now.

Code related list:

  • All in-code documentation related to this PR is up to date (Doxygen format)
  • Lethe documentation is up to date
  • Fix has unit test(s) (preferred) or application test(s), and restart files are in the generator folder
  • The branch is rebased onto master
  • Changelog (CHANGELOG.md) is up to date
  • Code is indented with indent-all and .prm files (examples and tests) with prm-indent

Pull request related list:

  • Labels are applied
  • There are at least 2 reviewers (or 1 if small feature) excluding the responsible for the merge
  • If this PR closes an issue or is related to a project, it is linked in the "Projects" or "Development" section
  • If the fix is temporary, an issue is opened
  • The PR description is cleaned and ready for merge

@blaisb blaisb requested a review from oguevremont August 18, 2024 02:38
@blaisb blaisb merged commit b255a9e into master Aug 18, 2024
9 of 10 checks passed
@blaisb blaisb deleted the debug_ci_fix branch August 18, 2024 03:44
M-Badri pushed a commit to M-Badri/lethe that referenced this pull request Sep 29, 2024
Description
There were some asserts being thrown in debug mode. These asserts were all warrented.
They were cuased by the following:
1- std::shared_ptr cannot be created from a nullptr. Since the sharp edge in the tracer relies on this mechanism to assess if there is or not a shape, this was highly problematic. @oguevremont we will need to look more into this and refactor this more cleanly in the next month. I have made a solution using regular pointers which is fine, but relying on nullptr is not very nice in my opinion
2- There was an std::vector that was not used correctly in the find cell around flat mechanism
3- In the restart for sharp edge, the order of the checks was not done in the right order which violated the size issue.

Solution
Fixed all of those bugs.

Testing
Debug tests should pass now.

Former-commit-id: b255a9e
blaisb added a commit that referenced this pull request Sep 30, 2024
Description
There were some asserts being thrown in debug mode. These asserts were all warrented.
They were cuased by the following:
1- std::shared_ptr cannot be created from a nullptr. Since the sharp edge in the tracer relies on this mechanism to assess if there is or not a shape, this was highly problematic. @oguevremont we will need to look more into this and refactor this more cleanly in the next month. I have made a solution using regular pointers which is fine, but relying on nullptr is not very nice in my opinion
2- There was an std::vector that was not used correctly in the find cell around flat mechanism
3- In the restart for sharp edge, the order of the checks was not done in the right order which violated the size issue.

Solution
Fixed all of those bugs.

Testing
Debug tests should pass now.

Former-commit-id: b255a9e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant