Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CLANG Tidy as a CI step #1241

Merged
merged 14 commits into from
Aug 15, 2024
Merged

Add CLANG Tidy as a CI step #1241

merged 14 commits into from
Aug 15, 2024

Conversation

blaisb
Copy link
Contributor

@blaisb blaisb commented Aug 15, 2024

Description

Our current CI has a check for GCC warnings, but this is clearly not as deep as the tests done by clang tidy. I am adding a new CI step to check the code using clang tidy. Right now this will throw some warnings and errors which I will fix progressively.

Testing

This is actually adding tests, so I am using this PR as a testing environment.
Code related list:

  • All in-code documentation related to this PR is up to date (Doxygen format)
  • Lethe documentation is up to date
  • New feature has unit test(s) (preferred) or application test(s), and restart files are in the generator folder
  • The branch is rebased onto master
  • Changelog (CHANGELOG.md) is up to date
  • Code is indented with indent-all and .prm files (examples and tests) with prm-indent

Pull request related list:

  • Labels are applied
  • There are at least 2 reviewers (or 1 if small feature) excluding the responsible for the merge
  • If this PR closes an issue or is related to a project, it is linked in the "Projects" or "Development" section
  • If the fix is temporary, an issue is opened
  • The PR description is cleaned and ready for merge

@blaisb blaisb merged commit 201d407 into master Aug 15, 2024
8 of 10 checks passed
@blaisb blaisb deleted the add_clang_tidy branch August 15, 2024 21:57
M-Badri pushed a commit to M-Badri/lethe that referenced this pull request Sep 29, 2024
Description
Our current CI has a check for GCC warnings, but this is clearly not as deep as the tests done by clang tidy. I am adding a new CI step to check the code using clang tidy. Right now this will throw some warnings and errors which I will fix progressively.

Testing
This is actually adding tests, so I am using this PR as a testing environment.
Code related list:



Former-commit-id: 201d407
blaisb added a commit that referenced this pull request Sep 30, 2024
Description
Our current CI has a check for GCC warnings, but this is clearly not as deep as the tests done by clang tidy. I am adding a new CI step to check the code using clang tidy. Right now this will throw some warnings and errors which I will fix progressively.

Testing
This is actually adding tests, so I am using this PR as a testing environment.
Code related list:



Former-commit-id: 201d407
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant