Move includes after #define in DEM #1223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blaisb
approved these changes
Aug 5, 2024
source/dem/CMakeLists.txt
Outdated
| @@ -37,7 +37,7 @@ add_library(lethe-dem | |||
| particle_wall_linear_force.cc | |||
| particle_wall_nonlinear_force.cc | |||
| periodic_boundaries_manipulator.cc | |||
| post_processing.cc | |||
| dem_post_processing.cc | |||
There was a problem hiding this comment.
Suggested change
| dem_post_processing.cc | |
| dem_post_processing.cc |
Can you put in alphabetical order please
source/dem/CMakeLists.txt
Outdated
| @@ -90,7 +90,7 @@ add_library(lethe-dem | |||
| ../../include/dem/particle_wall_linear_force.h | |||
| ../../include/dem/particle_wall_nonlinear_force.h | |||
| ../../include/dem/periodic_boundaries_manipulator.h | |||
| ../../include/dem/post_processing.h | |||
| ../../include/dem/dem_post_processing.h | |||
There was a problem hiding this comment.
Can you put in alphabetical order please
There was a problem hiding this comment.
Sorry about that, I never saw the file because I use the refactor tools in CLion and forget about that detail
acdaigneault
force-pushed
the
dem_cleanup-headers
branch
from
412b34b to
4fa1b6d
Compare
M-Badri
pushed a commit
to M-Badri/lethe
that referenced
this pull request
Sep 29, 2024
Description Quick refactor as done in PR chaos-polymtl#1170 that moves header includes after the #define. Some @brief has been added here and there at the same time. Former-commit-id: 9beea0c
blaisb
pushed a commit
that referenced
this pull request
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Quick refactor as done in PR #1170 that moves header includes after the #define.
Some @brief has been added here and there at the same time.
Miscellaneous (will be removed when merged)
I tried to add @brief, but did not really worked on the content of the doc since this was not the aim of this refactoring.
Checklist (will be removed when merged)
See this page for more information about the pull request process.
Code related list:
Pull request related list: