Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove gear3 integrator #1221

Merged
merged 2 commits into from
Aug 5, 2024
Merged

Remove gear3 integrator #1221

merged 2 commits into from
Aug 5, 2024

Conversation

blaisb
Copy link
Contributor

@blaisb blaisb commented Aug 4, 2024

Description

The Gear3 integrator was not used anywhere in the code in any example or in any tests. This integrator never gave good performance and was actually not tested for years. I believe it is now time to fully delete it. I want to work on adding new integrators this year and this will require some more unification. I want to start by cleaning things before adding new things.

Testing

There were actually no test for gear3...

Documentation

I adapted the documentation but the gear3 integrator was never mentioned in the documentation.

Miscellaneous (will be removed when merged)

Checklist (will be removed when merged)

See this page for more information about the pull request process.

Code related list:

  • All in-code documentation related to this PR is up to date (Doxygen format)
  • Lethe documentation is up to date
  • The branch is rebased onto master
  • Code is indented with indent-all and .prm files (examples and tests) with prm-indent
  • If parameters are modified, the tests and the documentation of examples are up to date
  • Changelog (CHANGELOG.md) is up to date if the refactor affects the user experience or the codebase

Pull request related list:

  • No other PR is open related to this refactoring
  • Labels are applied
  • There are at least 2 reviewers (or 1 if small feature) excluding the responsible for the merge
  • If this PR closes an issue or is related to a project, it is linked in the "Projects" or "Development" section
  • If any future works is planed, an issue is opened
  • The PR description is cleaned and ready for merge

@blaisb blaisb added Maintenance Ready for review Refactoring This PR is only refactoring or clean up labels Aug 4, 2024
@blaisb blaisb merged commit c32cbf7 into master Aug 5, 2024
8 checks passed
@blaisb blaisb deleted the remove_dem_gear_integrator branch August 5, 2024 13:46
M-Badri pushed a commit to M-Badri/lethe that referenced this pull request Sep 29, 2024
Description
The Gear3 integrator was not used anywhere in the code in any example or in any tests. This integrator never gave good performance and was actually not tested for years. I believe it is now time to fully delete it. I want to work on adding new integrators this year and this will require some more unification. I want to start by cleaning things before adding new things.

Testing
There were actually no test for gear3...

Documentation
I adapted the documentation but the gear3 integrator was never mentioned in the documentation.

Former-commit-id: c32cbf7
blaisb added a commit that referenced this pull request Sep 30, 2024
Description
The Gear3 integrator was not used anywhere in the code in any example or in any tests. This integrator never gave good performance and was actually not tested for years. I believe it is now time to fully delete it. I want to work on adding new integrators this year and this will require some more unification. I want to start by cleaning things before adding new things.

Testing
There were actually no test for gear3...

Documentation
I adapted the documentation but the gear3 integrator was never mentioned in the documentation.

Former-commit-id: c32cbf7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Maintenance Ready for review Refactoring This PR is only refactoring or clean up
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants