DEM example with a particle discharge from a plate with ASC and LB #1191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acdaigneault
added
Needs more reviewers
acdaigneault
added
Ready for review
and removed
Needs more reviewers
blaisb
reviewed
Jul 9, 2024
doc/source/examples/dem/plate-discharge/images/angle-of-repose.png
Outdated
Show resolved
Hide resolved
blaisb
reviewed
Jul 9, 2024
hepap
reviewed
Jul 9, 2024
oguevremont
reviewed
Jul 10, 2024
doc/source/examples/unresolved-cfd-dem/dense-pneumatic-conveying/dense-pneumatic-conveying.rst
Outdated
Show resolved
Hide resolved
hepap
reviewed
Jul 10, 2024
doc/source/examples/unresolved-cfd-dem/dense-pneumatic-conveying/dense-pneumatic-conveying.rst
Outdated
Show resolved
Hide resolved
examples/dem/3d-plate-discharge/plate-discharge_post-processing.py
Outdated
Show resolved
Hide resolved
|
Personally I don't have additional comments atop the already good ones that have been posted here. |
Co-authored-by: Olivier Guévremont <guevremont.o@gmail.com> Co-authored-by: hepap <47506601+hepap@users.noreply.github.com>
acdaigneault
force-pushed
the
example-DEM-ASC
branch
from
9bd41a2 to
5b877ef
Compare
acdaigneault
added
Ready for review
and removed
Reviewed and waiting for changes
labels
acdaigneault
requested review from
oguevremont,
hepap,
blaisb and
AmishgaAlphonius
oguevremont
approved these changes
Jul 15, 2024
AmishgaAlphonius
approved these changes
Jul 16, 2024
examples/dem/3d-plate-discharge/plate-discharge_post-processing.py
Outdated
Show resolved
Hide resolved
doc/source/examples/unresolved-cfd-dem/dense-pneumatic-conveying/dense-pneumatic-conveying.rst
Outdated
Show resolved
Hide resolved
|
I think I adressed all comments, thank you guys :) |
acdaigneault
added
Reviewed and ready to merge
and removed
Reviewed and waiting for changes
labels
M-Badri
pushed a commit
to M-Badri/lethe
that referenced
this pull request
Sep 29, 2024
…haos-polymtl#1191) Description The example is a simple case of particle discharging from a plate that compares the computational performance and the angle of repose of simulations using the Adaptive Sparse Contacts, the dynamic Load Balancing and both of them from a baseline simulation. The simulations have 52000 particles and run under 45 minutes each. This is the first example describing the ASC method. Co-authored-by: Olivier Guévremont <guevremont.o@gmail.com> Co-authored-by: hepap <47506601+hepap@users.noreply.github.com> Former-commit-id: 26d8692
blaisb
pushed a commit
that referenced
this pull request
Sep 30, 2024
…1191) Description The example is a simple case of particle discharging from a plate that compares the computational performance and the angle of repose of simulations using the Adaptive Sparse Contacts, the dynamic Load Balancing and both of them from a baseline simulation. The simulations have 52000 particles and run under 45 minutes each. This is the first example describing the ASC method. Co-authored-by: Olivier Guévremont <guevremont.o@gmail.com> Co-authored-by: hepap <47506601+hepap@users.noreply.github.com> Former-commit-id: 26d8692
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The example is a simple case of particle discharging from a plate that compares the computational performance and the angle of repose of simulations using the Adaptive Sparse Contacts, the dynamic Load Balancing and both of them from a baseline simulation.
The simulations have 52000 particles and run under 45 minutes each.
This is the first example describing the ASC method.
Miscellaneous (will be removed when merged)
I will have to rebase to master after the example of Cleo is merged because of the conflicts in the .rst DEM exemples page.
Checklist (will be removed when merged)
See this page for more information about the pull request process.
Code related list:
Pull request related list: