-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update installation doc #1183
Merged
Merged
Update installation doc #1183
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
d4b99b6
Update installation doc
AmishgaAlphonius 5bb35a7
Integrate new lines in the table
oguevremont 9f2eac9
Update doc/source/installation/apple_arm.rst
AmishgaAlphonius 552f054
Update doc/source/installation/regular_installation.rst
AmishgaAlphonius 8c6a264
Apply suggestions from code review
AmishgaAlphonius 5a17a18
Fix table indentation
AmishgaAlphonius File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -70,7 +70,7 @@ When prompted "do you want to continue?", proceed by typing ``y`` and hitting `` | |
5. |win_shell| (optional) For better ease in the Linux terminal (better coloring, multiple tabs), change the default terminal: | ||
|
||
* in the microsoft store, download ``Windows Terminal`` | ||
* in the ``parameters`` of ``Windows Terminal``, select on the left pannel "start": change default profile with ``Ubuntu-22.04`` | ||
* in the ``parameters`` of ``Windows Terminal``, select on the left panel "start": change default profile with ``Ubuntu-22.04`` | ||
* from now on, you can use this application instead to launch Ubuntu terminal | ||
|
||
.. tip:: | ||
|
@@ -202,7 +202,7 @@ Do not forget the ``.`` at the end of the command, which means "here". | |
* open the ``candi.cfg`` file with notepad (or other text editor) and change the following lines: | ||
|
||
+--------+------------------------------------------+----------------------------------------+ | ||
| line # | initial parameter | changed parameter | | ||
| line # | initial line | changed line | | ||
+========+==========================================+========================================+ | ||
| 7 | ``CLEAN_BUILD=OFF`` | ``CLEAN_BUILD=ON`` | | ||
+--------+------------------------------------------+----------------------------------------+ | ||
|
@@ -219,7 +219,7 @@ Do not forget the ``.`` at the end of the command, which means "here". | |
The prefix ``#`` is used to comment a line. Here we are simply commenting lines 44 and 45, and uncommenting lines 50 and 51, to change the trilinos version. | ||
|
||
+--------+------------------------------------------------+-----------------------------------------------+ | ||
| line # | initial parameter | changed parameter | | ||
| line # | initial line | changed line | | ||
+========+================================================+===============================================+ | ||
| 44 | ``VERSION=12-18-1`` | ``#VERSION=12-18-1`` | | ||
+--------+------------------------------------------------+-----------------------------------------------+ | ||
|
@@ -234,21 +234,25 @@ Do not forget the ``.`` at the end of the command, which means "here". | |
* still in the subfolder ``deal.II-toolchain/packages/``, open the ``p4est.package`` file with notepad and change the following lines: | ||
|
||
.. tip:: | ||
The prefix ``#`` is used to comment a line. Here we are simply uncommenting line 7, and commenting lines 9 to 12, to change the p4est version. | ||
|
||
+--------+------------------------------------------------+-----------------------------------------------+ | ||
| line # | initial parameter | changed parameter | | ||
+========+================================================+===============================================+ | ||
| 7 | ``#VERSION=2.2;CHECKSUM=6943949a...`` | ``VERSION=2.2;CHECKSUM=6943949a...`` | | ||
+--------+------------------------------------------------+-----------------------------------------------+ | ||
| 9 | ``VERSION=2.3.2`` | ``#VERSION=2.3.2`` | | ||
+--------+------------------------------------------------+-----------------------------------------------+ | ||
| 10 | ``CHECKSUM=076df9e...`` | ``#CHECKSUM=076df9e...`` | | ||
+--------+------------------------------------------------+-----------------------------------------------+ | ||
| 11 | ``CHECKSUM="${CHECKSUM} b41c8ef29ca...`` | ``#CHECKSUM="${CHECKSUM} b41c8ef29ca...`` | | ||
+--------+------------------------------------------------+-----------------------------------------------+ | ||
| 12 | ``CHECKSUM="${CHECKSUM} 0ea6e4806b6...`` | ``#CHECKSUM="${CHECKSUM} 0ea6e4806b6...`` | | ||
+--------+------------------------------------------------+-----------------------------------------------+ | ||
The prefix ``#`` is used to comment a line. Here we are commenting lines 9 to 12 and adding 2 new lines to change the p4est version. | ||
|
||
+--------+------------------------------------------------+-------------------------------------------------------------------------------+ | ||
| line # | initial line | changed line | | ||
+========+================================================+===============================================================================+ | ||
| 9 | ``VERSION=2.3.2`` | ``#VERSION=2.3.2`` | | ||
+--------+------------------------------------------------+-------------------------------------------------------------------------------+ | ||
| 10 | ``CHECKSUM=076df9e...`` | ``#CHECKSUM=076df9e...`` | | ||
+--------+------------------------------------------------+-------------------------------------------------------------------------------+ | ||
| 11 | ``CHECKSUM="${CHECKSUM} b41c8ef29ca...`` | ``#CHECKSUM="${CHECKSUM} b41c8ef29ca...`` | | ||
+--------+------------------------------------------------+-------------------------------------------------------------------------------+ | ||
| 12 | ``CHECKSUM="${CHECKSUM} 0ea6e4806b6...`` | ``#CHECKSUM="${CHECKSUM} 0ea6e4806b6...`` | | ||
+--------+------------------------------------------------+-------------------------------------------------------------------------------+ | ||
| 13 | | .. code-block:: text | | ||
| | | :class: copy-button | | ||
| | | | | ||
| | | VERSION=2.3.6 | | ||
| | | CHECKSUM=4b35d9cc374e3b05cd29c552070940124f04af8f8e5e01ff046e39833de5e153 | | ||
+--------+------------------------------------------------+-------------------------------------------------------------------------------+ | ||
|
||
* save and close | ||
|
||
|
@@ -297,7 +301,7 @@ Where ``$numprocs`` corresponds to the number of processors used for the compila | |
Installing Lethe (Step #2) | ||
------------------------------------- | ||
|
||
1. |linux_shell| Set-up the folder structure. Create the ``Software`` folder (if you are doing the candi installation, this folder should alredy exist from Step #1). | ||
1. |linux_shell| Set-up the folder structure. Create the ``Software`` folder (if you are doing the candi installation, this folder should already exist from Step #1). | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The only thing I don't like is that Software here is with a capital letter. Haha. Otherwise, chill |
||
|
||
.. code-block:: text | ||
:class: copy-button | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this format for adding new lines. I suggest we write it the same way for regular installation and Apple ARM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was hesistating between both format, so I thought leaving them both here, the reviewers will tell me their opinion. Thanks for making the change!