CFD-DEM Pneumatic Conveying Example #1178

acdaigneault · 2024-06-20T17:52:07Z

Description

This example is a small case of dense pneumatic conveying using CFD-DEM unresolved.
The insertion uses the plane insertion, solid objects and the adaptive sparse contacts method.
The pneumatic conveying is simulated using the CFD and DEM periodic boundary conditions and a flow controller.

Miscellaneous (will be removed when merged)

This code uses the adaptive sparse contacts for the loading of particles because it is well-suited for that, but I am planing to explain it in details in another example, this is why there's not much comments about it.

https://www.youtube.com/watch?v=4uM51PCypZc
https://www.youtube.com/watch?v=ESfSrmmlzYE

Checklist (will be removed when merged)

See this page for more information about the pull request process.

Code related list:

Lethe documentation is up to date
The branch is rebased onto master
Code is indented with indent-all and .prm files (examples and tests) with prm-indent
Links are added to parent .rst files.

Pull request related list:

Labels are applied
There are at least 2 reviewers (or 1 if small feature) excluding the responsible for the merge
If this PR closes an issue or is related to a project, it is linked in the "Projects" or "Development" section
If any future works is planed, an issue is opened
The PR description is cleaned and ready for merge

examples/dem/3d-rectangular-hopper/hopper.prm

doc/source/examples/unresolved-cfd-dem/dense-pneumatic-conveying/images/insertion.png

OresteMarquis

Really nice work Audrey! Nothing much to say for your doc, it is really clear and pretty :) I was not able to test if the youtube html link work (I am not a pro of html), but I trust you on this!

contrib/utilities/check_parameter_files_in_examples.sh

doc/source/examples/unresolved-cfd-dem/dense-pneumatic-conveying/dense-pneumatic-conveying.rst

examples/unresolved-cfd-dem/dense-pneumatic-conveying/output/dummy-file

doc/source/examples/unresolved-cfd-dem/dense-pneumatic-conveying/dense-pneumatic-conveying.rst

AmishgaAlphonius

Very nice example and footnotes are great for the references ! :)
Great videos also!!
I only have minor comments :)

doc/source/examples/unresolved-cfd-dem/dense-pneumatic-conveying/dense-pneumatic-conveying.rst

doc/source/examples/unresolved-cfd-dem/dense-pneumatic-conveying/images/insertion.png

doc/source/examples/unresolved-cfd-dem/dense-pneumatic-conveying/dense-pneumatic-conveying.rst

blaisb

Some initial comments, I have not reviewed the RST file yet, will do so tonight

doc/source/parameters/cfd/dynamic_flow_control.rst

contrib/utilities/check_parameter_files_in_examples.sh

doc/source/examples/unresolved-cfd-dem/dense-pneumatic-conveying/images/insertion.png

doc/source/examples/unresolved-cfd-dem/dense-pneumatic-conveying/images/mesh-particle.png

contrib/utilities/check_parameter_files_in_examples.sh

blaisb

Only a few comments there and there. Amazing example. Very cool.

doc/source/examples/unresolved-cfd-dem/dense-pneumatic-conveying/dense-pneumatic-conveying.rst

blaisb

All is good other than the missing python script. Once added just tell me and I'll be ready for a merge from my perspective.

doc/source/parameters/cfd/dynamic_flow_control.rst

doc/source/examples/unresolved-cfd-dem/dense-pneumatic-conveying/dense-pneumatic-conveying.rst

acdaigneault · 2024-06-23T20:31:07Z

Thank you all for the good review and comments, I like when we discuss about small things like that, even though I may sound a bit stubborn haha
The post-processing code is added :)

acdaigneault · 2024-06-23T20:32:29Z

@blaisb I don't know if you want at least a review of the post-processing before the merge?

blaisb

Good for me but I will wait until @AmishgaAlphonius and @OresteMarquis finalize their review before merging

contrib/utilities/check_parameter_files_in_examples.sh

blaisb · 2024-06-24T13:28:09Z

doc/source/examples/unresolved-cfd-dem/dense-pneumatic-conveying/dense-pneumatic-conveying.rst

+.. code-block:: text
+  :class: copy-button
+
+  mpirun -np 8 lethe-fluid-particles pneumatic-conveying.prm | tee pneumatic-log.out


awesome :).

OresteMarquis

Nice! Everything looks good to me! I like the new convention of something-particles :)

blaisb · 2024-06-25T15:23:35Z

I'll just wait for @AmishgaAlphonius last ok and then good ot merge

AmishgaAlphonius

Just one comment on a mistyped filename other than that everything looks good. Again, great example !! :)

AmishgaAlphonius · 2024-06-25T20:06:16Z

.github/PULL_REQUEST_TEMPLATE/pull_request_template_example.md

@@ -21,7 +21,8 @@ Code related list:
 - [ ] Lethe documentation is up to date
 - [ ] The branch is rebased onto master
 - [ ] Code is indented with indent-all and .prm files (examples and tests) with prm-indent
- [ ] Links are added to parent .rst files.
+- [ ] Links are added to parent .rst files
+- [ ] The example is following the [standard format](https://chaos-polymtl.github.io/lethe/documentation/contributing.html#general-rules-and-format)


Nice addition! :)

AmishgaAlphonius · 2024-06-25T20:10:35Z

examples/unresolved-cfd-dem/dense-pneumatic-conveying/pneumatic-conveying_post-processing.py

The filename doesn't correspond to what's in the rst.

doc/source/examples/unresolved-cfd-dem/dense-pneumatic-conveying/dense-pneumatic-conveying.rst

Co-authored-by: Amishga Alphonius <107414376+AmishgaAlphonius@users.noreply.github.com>

Co-authored-by: Bruno Blais <blais.bruno@gmail.com>

Description This example is a small case of dense pneumatic conveying using CFD-DEM unresolved. The insertion uses the plane insertion, solid objects and the adaptive sparse contacts method. The pneumatic conveying is simulated using the CFD and DEM periodic boundary conditions and a flow controller. Co-authored-by: Amishga Alphonius <107414376+AmishgaAlphonius@users.noreply.github.com> Co-authored-by: Bruno Blais <blais.bruno@gmail.com> Former-commit-id: b5fdce1

acdaigneault added WIP When a PR is open but not ready for review Needs more reviewers This pull request needs more review before a merge is possible Example labels Jun 20, 2024

acdaigneault commented Jun 20, 2024

View reviewed changes

examples/dem/3d-rectangular-hopper/hopper.prm Outdated Show resolved Hide resolved

acdaigneault force-pushed the example_pneumatic-conveying branch from bca64d6 to d116a9d Compare June 20, 2024 17:57

acdaigneault commented Jun 20, 2024

View reviewed changes

doc/source/examples/unresolved-cfd-dem/dense-pneumatic-conveying/images/insertion.png Outdated Show resolved Hide resolved

blaisb requested review from OresteMarquis and AmishgaAlphonius June 20, 2024 20:14

acdaigneault added Ready for review and removed WIP When a PR is open but not ready for review Needs more reviewers This pull request needs more review before a merge is possible labels Jun 20, 2024

acdaigneault requested a review from blaisb June 20, 2024 22:27

OresteMarquis requested changes Jun 21, 2024

View reviewed changes

acdaigneault requested a review from OresteMarquis June 21, 2024 15:56

AmishgaAlphonius reviewed Jun 21, 2024

View reviewed changes

acdaigneault commented Jun 21, 2024

View reviewed changes

doc/source/examples/unresolved-cfd-dem/dense-pneumatic-conveying/dense-pneumatic-conveying.rst Outdated Show resolved Hide resolved

blaisb requested changes Jun 21, 2024

View reviewed changes

blaisb requested changes Jun 22, 2024

View reviewed changes

blaisb approved these changes Jun 23, 2024

View reviewed changes

doc/source/parameters/cfd/dynamic_flow_control.rst Show resolved Hide resolved

doc/source/examples/unresolved-cfd-dem/dense-pneumatic-conveying/dense-pneumatic-conveying.rst Show resolved Hide resolved

acdaigneault requested review from AmishgaAlphonius and blaisb June 23, 2024 20:31

acdaigneault added Post-processing Modifications to the post-processing module and removed Post-processing Modifications to the post-processing module labels Jun 23, 2024

blaisb approved these changes Jun 24, 2024

View reviewed changes

OresteMarquis approved these changes Jun 24, 2024

View reviewed changes

AmishgaAlphonius approved these changes Jun 25, 2024

View reviewed changes

acdaigneault commented Jun 25, 2024

View reviewed changes

doc/source/examples/unresolved-cfd-dem/dense-pneumatic-conveying/dense-pneumatic-conveying.rst Outdated Show resolved Hide resolved

blaisb added Reviewed and ready to merge and removed Ready for review labels Jun 25, 2024

acdaigneault and others added 23 commits July 1, 2024 23:09

Add simulation files for example

a101673

First part of example

8376a77

Include the new example

b66381e

example cont

1b215cc

update

25a6ce4

New parameters and doc

5b084a0

Finish doc

ec63529

Add iamges

5faddfe

White backgroung

1f91ef9

Fix typos

1c479fa

Update .prm to master

064768f

Change references format

f1f9ed0

Apply review comments and change the quasi-steady state

f2ff1f1

Apply review comments from Amishga and Bruno

53c8df7

Apply suggestions from code review

97f9e0e

Co-authored-by: Amishga Alphonius <107414376+AmishgaAlphonius@users.noreply.github.com>

Review the sections of example

1ece5c7

Reformat flow control eqt

f1f0e59

Add figures in description

e3dbb64

Rename DEM prm in CFD-DEM as "*action*-particles.prm"

1a8f085

Change m to mm

643b553

Add post-processing code

11fbdef

Apply suggestions from code review

8ee3367

Co-authored-by: Bruno Blais <blais.bruno@gmail.com>

Fix typo

a25684c

blaisb force-pushed the example_pneumatic-conveying branch from af45001 to a25684c Compare July 1, 2024 23:11

blaisb merged commit b5fdce1 into master Jul 1, 2024
8 checks passed

blaisb deleted the example_pneumatic-conveying branch July 1, 2024 23:12

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

CFD-DEM Pneumatic Conveying Example #1178

CFD-DEM Pneumatic Conveying Example #1178

acdaigneault commented Jun 20, 2024 •

edited

Loading

OresteMarquis left a comment

AmishgaAlphonius left a comment

blaisb left a comment

blaisb left a comment

blaisb left a comment

acdaigneault commented Jun 23, 2024

acdaigneault commented Jun 23, 2024

blaisb left a comment

blaisb Jun 24, 2024

OresteMarquis left a comment

blaisb commented Jun 25, 2024

AmishgaAlphonius left a comment

AmishgaAlphonius Jun 25, 2024

AmishgaAlphonius Jun 25, 2024

CFD-DEM Pneumatic Conveying Example #1178

CFD-DEM Pneumatic Conveying Example #1178

Conversation

acdaigneault commented Jun 20, 2024 • edited Loading

Description

Miscellaneous (will be removed when merged)

Checklist (will be removed when merged)

OresteMarquis left a comment

Choose a reason for hiding this comment

AmishgaAlphonius left a comment

Choose a reason for hiding this comment

blaisb left a comment

Choose a reason for hiding this comment

blaisb left a comment

Choose a reason for hiding this comment

blaisb left a comment

Choose a reason for hiding this comment

acdaigneault commented Jun 23, 2024

acdaigneault commented Jun 23, 2024

blaisb left a comment

Choose a reason for hiding this comment

blaisb Jun 24, 2024

Choose a reason for hiding this comment

OresteMarquis left a comment

Choose a reason for hiding this comment

blaisb commented Jun 25, 2024

AmishgaAlphonius left a comment

Choose a reason for hiding this comment

AmishgaAlphonius Jun 25, 2024

Choose a reason for hiding this comment

AmishgaAlphonius Jun 25, 2024

Choose a reason for hiding this comment

acdaigneault commented Jun 20, 2024 •

edited

Loading