Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for list outputs with optionals #613

Closed
wants to merge 1 commit into from

Conversation

rhpvorderman
Copy link
Contributor

Motivation

I found a bug when running this task: https://github.com/biowdl/tasks/blob/a980f109ae7e3d13e8bc26e27b4411cc94f0eeb3/picard.wdl#L139

The task has lots and lots of outputs. Some of which are optional. Therefore an allOutputs variable is created on a list of all outputs using select_all. Miniwdl crashes on this latter list variable. I have created a reproducing test case.

Approach

TODO: Actually fix the bug

@mlin
Copy link
Collaborator

mlin commented Nov 22, 2022

Included in 4def324 thanks#

@mlin mlin closed this Nov 22, 2022
@rhpvorderman
Copy link
Contributor Author

Thanks! I will continue testing miniwdl with biowdl and report what shows up. (And also report if nothing shows up). Preliminary data shows that we can shorten some of the tests that take 10 minutes with cromwell to just 2 minutes with miniwdl. I am quite excited about this.

@rhpvorderman rhpvorderman deleted the relpaths_none branch November 22, 2022 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants