Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] aws cred_process redirects stderr to /dev/tty such that users can see mfa prompts #396

Merged
merged 2 commits into from
Jan 28, 2020

Conversation

edulop91
Copy link
Contributor

Summary

botocore will consume both stderr and stdout for their cred_process. We use this hack to make sure that stderr is displayed back to the user. stdout is still consumed by botocore as normal.

Test Plan

aws sts get-caller-identity --profile XXXXXX
INFO[0001] Requesting MFA. Please complete two-factor authentication with your second device             
INFO[0002] Device: XXXXXXX                               
{
    "Account": "XXXXXXXX", 
    "UserId": "XXXXXX", 
    "Arn": "arn:aws:sts::XXXX:assumed-role/XXXX/XXXX"
}

References

boto/botocore#1348

@edulop91 edulop91 requested a review from a team as a code owner January 28, 2020 20:09
@codecov
Copy link

codecov bot commented Jan 28, 2020

Codecov Report

Merging #396 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #396   +/-   ##
=======================================
  Coverage   79.22%   79.22%           
=======================================
  Files          25       25           
  Lines        2026     2026           
=======================================
  Hits         1605     1605           
  Misses        278      278           
  Partials      143      143

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e1461fb...4f7c749. Read the comment docs.

Copy link
Contributor

@ryanking ryanking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, but @jgadling might have good feedback

@edulop91
Copy link
Contributor Author

I'll apply @jgadling feedback in a followup pr

@edulop91 edulop91 merged commit edf05af into master Jan 28, 2020
@edulop91 edulop91 deleted the edu/credential_process_tty branch January 28, 2020 20:33
palasha pushed a commit to palasha/fogg that referenced this pull request Apr 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants