Rework of some concepts #157
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… v16 compatibility
…parseArgs" Changed package to es6
…. version, help, migrate, ...
…_config_XYZ instead of processArgv (part 1); Removed some unused things; Renamed some typos
…ould use a name they like not necessarily "start"; Enforcing "LF" as line ending
…and options (e.g. --confirm); Replaced some hardcoded versions in win32 tests with $version placeholder;
…me (they need to be comma-separated as of now)
…pt to new concept for multiple commands (scripts) at the same time;
…to the internal command/script
…Renamed internal "dry" option to match native NPM implementation of dry_run
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @Heerschop, with this PR I've reworked some concepts to be able to fix internal scripts (e.g.
help,version) as well as being able to transport variables to scripts (e.g.foo:bar $1 $2) this wasn't working along with internal commands in previous versions.I've restricted commands (scripts) to be used without "--" prefix (e.g.
--helpwill not work anymore) and options with "--" prefix (which is enforced by NPM anyway and not preserved on the processArgv array).Additional I've adapted the implementation of options (
--dry,--confirm=false, ...) according to NPM to useprocess.env.npm_config_xyz.Coming with this there were conflicts with the options of NPM itself (e.g.
--dry,--dry-run,--dryRunare all converted tonpm_config_dry_run, also--loglevelis a string and not a number).Also I've changed the concept of how multiple scripts are preserved by the user (previously:
npx launch foo:bar foo:baz, nownpx launch foo:bar,foo:baz)I guess this should not be published as a patch version update but a major (2.0.0 as the multi-commands are breaking) or minor version instead (1.38.0 as I've added to the CHANGELOG.md file).