Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Basic fix for avoiding blocking of the consumer thread. #98

Merged
merged 1 commit into from
Mar 2, 2023
Merged

Basic fix for avoiding blocking of the consumer thread. #98

merged 1 commit into from
Mar 2, 2023

Conversation

diegodiv
Copy link
Contributor

@diegodiv diegodiv commented Mar 2, 2023

We want to avoid dependency of one thread to a blocking queue, by stopping writing in it if it's full, thus discarding the update. This is not the best model and needs to be improved on, but it can serve as a fix in some cases.

@diegodiv diegodiv requested a review from fatho March 2, 2023 09:50
fatho
fatho approved these changes Mar 2, 2023
View reviewed changes
Copy link
Member

@fatho fatho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but before cutting a new release, it'd be good to also add the metrics so that we at least have a way of observing that this happened.

@diegodiv diegodiv merged commit 8642cfe into master Mar 2, 2023
@diegodiv diegodiv deleted the dd/fix-write branch March 2, 2023 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fatho fatho fatho approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@diegodiv @fatho