Upgrade from LTS 18.18 to 19.17 and fix all breaking changes #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And also bump raven-haskell to the latest version.
The latest version of Web.JWT has split the Signer datatype into two versions: EncodeSigner and VerifySigner. The former is used to encode newly minted tokens, while the latter is used to verify signed tokens. I have updated the usage sites everywhere to use the right kind of token.
Shorter definition of alter
This required using EncodeSigner and VerifySigner in the right places
We now have to use KeyMap instead of HashMap
alex-mckenna
approved these changes
Aug 16, 2022
| @@ -13,7 +13,7 @@ import AccessControl | |||
| import JwtAuth | |||
|
|
|||
| data Config = Config | |||
| { configJwtSecret :: Maybe JWT.Signer | |||
| { configJwtSecret :: Maybe JWT.EncodeSigner | |||
There was a problem hiding this comment.
Maybe it would be a good idea to include a comment for this field so it's clear what it means if an EncodeSigner is not provided (similar to the comment already in server/src/Config.hs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR upgrades the stackage snapshot from 18.18 to 19.17.
This implies a GHC upgrade from 8.10 to 9.0.
There were breaking changes in two libraries:
Web.JWThas split the Signer datatype into two versions: EncodeSigner and VerifySigner. The former is used to encodenewly minted tokens, while the latter is used to verify signed tokens.
Data.Aesonhas hidden theHashMaptype behind aKeyMaptype which only exposesalterFinstead ofalterandadjust. I added the last two functions to keep the rest of the code the same.All the tests are passing again.