Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix service bug in windows #24

Merged
merged 5 commits into from
Sep 25, 2022
Merged

fix service bug in windows #24

merged 5 commits into from
Sep 25, 2022

Conversation

kvii
Copy link
Contributor

@kvii kvii commented Sep 10, 2022 •
edited by changkun
Loading

Fixes #19

changkun
changkun reviewed Sep 11, 2022
View reviewed changes
cmd/daemon.go Outdated Show resolved Hide resolved
internal/service/service_windows.go Outdated Show resolved Hide resolved
changkun
changkun approved these changes Sep 25, 2022
View reviewed changes
Copy link
Owner

@changkun changkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I looked high-level details and all changes seem reasonable to me.

@changkun changkun merged commit e6cf1b2 into changkun:main Sep 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@changkun changkun changkun approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

demon start failed in windows platform
2 participants
@kvii @changkun