Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix ticker not stop #21

Merged
merged 1 commit into from
Sep 10, 2022
Merged

fix ticker not stop #21

merged 1 commit into from
Sep 10, 2022

Conversation

kvii
Copy link
Contributor

@kvii kvii commented Sep 10, 2022

A ticker should be stopped when you don't need it.
But I haven't tested it.I also didn't find the related test.

@kvii
Copy link
Contributor Author

kvii commented Sep 10, 2022

??? It's not my fault.
The test failed when "Install and run dependencies (xvfb libx11-dev)".

changkun
changkun approved these changes Sep 10, 2022
View reviewed changes
Copy link
Owner

@changkun changkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch. Thanks!

@changkun changkun merged commit 84eb6ed into changkun:main Sep 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@changkun changkun changkun approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kvii @changkun