add mypy test requirement to fix known mypy bug in python/mypy#4117

chanedwin · Sep 20, 2020 · 7dea27d · 7dea27d
1 parent fed82f0
commit 7dea27d
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/requirements-test.txt b/requirements-test.txt
@@ -2,6 +2,8 @@ pytest
 coverage<5
 codecov
 pytest-mypy>=0.7.0
+# this is because mypy had an issue where singledispatch _ usage resulted in errors (https://github.com/python/mypy/issues/2904)
+mypy>=0.761
 pytest-cov
 pytest-black
 nbval

diff --git a/src/pandas_profiling/model/summary.py b/src/pandas_profiling/model/summary.py
@@ -44,7 +44,7 @@ def describe_1d(series, summarizer: BaseSummarizer, typeset) -> dict:
     raise NotImplementedError("Method is not implemented for dtype")
 
 
-@describe_1d.register
+@describe_1d.register(pd.Series)
 def _(series: pd.Series, summarizer: BaseSummarizer, typeset) -> dict:
     """
     if a pd.Series is provided, we should wrap it in the pandas series wrapper.
@@ -54,7 +54,7 @@ def _(series: pd.Series, summarizer: BaseSummarizer, typeset) -> dict:
     return describe_1d(PandasSeries(series), summarizer, typeset)
 
 
-@describe_1d.register
+@describe_1d.register(PandasSeries)
 def _(series: PandasSeries, summarizer: BaseSummarizer, typeset) -> dict:
     """Describe a series (infer the variable type, then calculate type-specific values).
 
@@ -76,7 +76,7 @@ def _(series: PandasSeries, summarizer: BaseSummarizer, typeset) -> dict:
     return summarizer.summarize(series, dtype=vtype)
 
 
-@describe_1d.register
+@describe_1d.register(SparkSeries)
 def _(series: SparkSeries, summarizer: BaseSummarizer, typeset) -> dict:
     """Describe a series (infer the variable type, then calculate type-specific values).