refactor: c++ 17 #7038
Draft
refactor: c++ 17 #7038
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShortDevelopment
changed the title
ShortDevelopment
force-pushed
the
feature/cpp-17
branch
from
bbfda98 to
3576eb9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LibICU now requires c++ 17 but CC currently uses c++ 11:
ChakraCore/CMakeLists.txt
Line 375 in 36becec
This causes MacOS ci to fail.
📣 Changes
thow(...)bool std::uncaught_exception()is replaced byint uncaught_exceptions()see uncaught_exception💥 Breaking changes
@ppenzin
Fixes #3147
Fixes #6378