OS#16115338 Update _.floor to normalize -0 to 0 [OSS-Fuzz] #4754
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MSLaguana
approved these changes
Feb 28, 2018
boingoing
approved these changes
Feb 28, 2018
dilijev
approved these changes
Feb 28, 2018
chakrabot
pushed a commit
that referenced
this pull request
Mar 1, 2018
…to 0 [OSS-Fuzz] Merge pull request #4754 from jackhorton:os16115338 The intl spec refers to the `floor` function in [DefaultNumberOption](https://tc39.github.io/ecma402/#sec-defaultnumberoption), which we had previously implemented as exactly Math.floor Math.floor is defined to return -0 when given -0 as input. However, DefaultNumberOption actually refers to [the floor mathematical operation](https://tc39.github.io/ecma262/#sec-mathematical-operations), which states that -0 should be normalized to 0, which is the more intuitive behavior. This fixes a FailFast that triggered when we couldn't retrieve the minimumFractionDigits as a TaggedInt.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The intl spec refers to the
floorfunction in DefaultNumberOption, which we had previously implemented as exactly Math.floor Math.floor is defined to return -0 when given -0 as input. However, DefaultNumberOption actually refers to the floor mathematical operation, which states that -0 should be normalized to 0, which is the more intuitive behavior.This fixes a FailFast that triggered when we couldn't retrieve the minimumFractionDigits as a TaggedInt.