Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bug in reattaching debugger for asm.js #15

Merged
merged 1 commit into from
Jan 9, 2016
Merged

fix bug in reattaching debugger for asm.js #15

merged 1 commit into from
Jan 9, 2016

Conversation

MikeHolman
Copy link
Contributor

Resolves #1
Debugger attach->detach->attach scenario is broken for asm.js. Some fields need to be cleaned up but aren't (notably AsmJsFunctionInfo). This scenario is most commonly hit through using the performance tab of f12 on pages with asm.js.

@msftclas
Copy link

msftclas commented Jan 6, 2016

Hi @MikeHolman, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!


It looks like you're a Microsoft contributor (Michael Holman). If you're full-time, we DON'T require a Contribution License Agreement. If you are a vendor, please DO sign the electronic Contribution License Agreement. It will take 2 minutes and there's no faxing! https://cla.microsoft.com.

TTYL, MSBOT;

funcList->Iterate([](AsmJsScriptFunction * func)
{
func->SetModuleMemory(nullptr);
func->GetFunctionBody()->ResetAsmJsInfo();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GetFunctionBody() guarantees to return non-null?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be in this list, scriptFunction->GetFunctionBody()->GetAsmJsFunctionInfo() must be non-null (from TransitionEnvironmentForDebugger). But that also assumes GetFunctionBody() is non-null.

From comment "// We should have force parsed the function, and have a function body" in RecyclerFunctionCallbackForDebugger, and my understanding that we full parse everything when we attach debugger, I took this as truth. If you want, I can add an assert here/in TransitionEnvironmentForDebugger, if nothing else but for the sake of clarity.

@akroshg
Copy link
Contributor

akroshg commented Jan 7, 2016

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants