Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move RegExp properties to the prototype #14

Merged
merged 3 commits into from
Jan 8, 2016
Merged

Move RegExp properties to the prototype #14

merged 3 commits into from
Jan 8, 2016

Conversation

goyakin
Copy link

@goyakin goyakin commented Jan 6, 2016

This change moves all instance properties except "lastIndex" to the prototype as accessor properties.

Gorkem Yakin added 3 commits January 6, 2016 12:15
This change moves all instance properties except "lastIndex" to the
prototype as accessor properties.
@msftclas
Copy link

msftclas commented Jan 6, 2016

Hi @goyakin, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!


It looks like you're a Microsoft contributor (Gorkem Yakin). If you're full-time, we DON'T require a Contribution License Agreement. If you are a vendor, please DO sign the electronic Contribution License Agreement. It will take 2 minutes and there's no faxing! https://cla.microsoft.com.

TTYL, MSBOT;

@goyakin
Copy link
Author

goyakin commented Jan 6, 2016

@kunalspathak & @abchatra, could you review this change?

@kunalspathak
Copy link
Contributor

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants