Skip to content

Commit

Permalink
[MERGE #6244 @wyrichte] Move signing for ChakraCore.dll and ch.exe to…
Browse files Browse the repository at this point in the history
… use a SHA2 cert

Merge pull request #6244 from wyrichte:build/wyrichte/will_this_work
  • Loading branch information
wyrichte committed Aug 13, 2019
2 parents 6b1250b + ea0882f commit e1f5b03
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion bin/ChakraCore/ChakraCore.vcxproj
Original file line number Diff line number Diff line change
Expand Up @@ -189,7 +189,7 @@
<!-- Conditionally include the group of files to sign because MBv2 knows what to do with this but the old build definition gets confused. -->
<ItemGroup Condition="'$(VSO_MICROBUILD_V2)'=='True' AND '$(POGO_TYPE)'!='PGI'">
<FilesToSign Include="$(OutDir)\ChakraCore.dll">
<Authenticode>Microsoft</Authenticode>
<Authenticode>Microsoft400</Authenticode>
</FilesToSign>
</ItemGroup>
<Import Project="$(BuildConfigPropsPath)Chakra.Build.targets" Condition="exists('$(BuildConfigPropsPath)Chakra.Build.targets')" />
Expand Down
2 changes: 1 addition & 1 deletion bin/ch/ch.vcxproj
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@
<!-- Conditionally include the group of files to sign because MBv2 knows what to do with this but the old build definition gets confused. -->
<ItemGroup Condition="'$(VSO_MICROBUILD_V2)'=='True' AND '$(POGO_TYPE)'!='PGI'">
<FilesToSign Include="$(OutDir)\ch.exe">
<Authenticode>Microsoft</Authenticode>
<Authenticode>Microsoft400</Authenticode>
</FilesToSign>
</ItemGroup>
<Import Project="$(BuildConfigPropsPath)Chakra.Build.targets" Condition="exists('$(BuildConfigPropsPath)Chakra.Build.targets')" />
Expand Down

0 comments on commit e1f5b03

Please sign in to comment.