Skip to content

Commit

Permalink
fix some 17-06 build breaks and CI copyright check failure
Browse files Browse the repository at this point in the history
  • Loading branch information
Jianchun Xu committed Jun 15, 2017
1 parent bb95963 commit 86b66ee
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 8 deletions.
7 changes: 0 additions & 7 deletions lib/Common/CommonDefines.h
Original file line number Diff line number Diff line change
Expand Up @@ -8,13 +8,6 @@
#include "Warnings.h"
#include "ChakraCoreVersion.h"

#if defined(NTBUILD) && defined(_CHAKRACOREBUILD)
#error NTBUILD and _CHAKRACOREBUILD cannot be both defined
#endif
#if !defined(NTBUILD) && !defined(_CHAKRACOREBUILD)
#error Either NTBUILD or _CHAKRACOREBUILD must be defined
#endif

//----------------------------------------------------------------------------------------------------
// Default debug/fretest/release flags values
// - Set the default values of debug/fretest/release flags if it is not set by the command line
Expand Down
2 changes: 2 additions & 0 deletions lib/Runtime/Library/JavascriptArray.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -5253,6 +5253,7 @@ namespace Js

if (hasInlineSegment)
{
AnalysisAssert(array->head);
SparseArraySegment<T>* newHeadSeg = array->ReallocNonLeafSegment((SparseArraySegment<T>*)PointerValue(array->head), array->head->next);
array->head = newHeadSeg;
}
Expand All @@ -5274,6 +5275,7 @@ namespace Js

if (SparseArraySegmentBase::IsLeafSegment(lastSeg, recycler))
{
AnalysisAssert(lastSeg);
arr->ReallocNonLeafSegment((SparseArraySegment<T>*)lastSeg, lastSeg->next, true /*forceNonLeaf*/);
}
}
Expand Down
2 changes: 1 addition & 1 deletion lib/Runtime/Library/JavascriptArray.inl
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ namespace Js
Recycler *recycler = this->GetScriptContext()->GetRecycler();
if (forceNonLeaf)
{
newSeg = SparseArraySegment<T>::AllocateSegmentImpl<false /*isLeaf*/>(recycler, seg->left, seg->length, nextSeg);
newSeg = SparseArraySegment<T>::template AllocateSegmentImpl<false /*isLeaf*/>(recycler, seg->left, seg->length, nextSeg);
}
else
{
Expand Down
5 changes: 5 additions & 0 deletions test/LetConst/shadowedsetter.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
//-------------------------------------------------------------------------------------------------------
// Copyright (C) Microsoft. All rights reserved.
// Licensed under the MIT license. See LICENSE.txt file in the project root for full license information.
//-------------------------------------------------------------------------------------------------------

evaluate = WScript.LoadScript;

__defineSetter__("x", function () { });
Expand Down

0 comments on commit 86b66ee

Please sign in to comment.